All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Samuel Tardieu <sam@rfc1149.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] tag: Do not allow to call "git tag" in more than one operating mode
Date: Tue, 04 Nov 2008 14:47:40 -0800	[thread overview]
Message-ID: <7vej1rqfar.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081104124207.18273.31679.stgit@arrakis.enst.fr> (Samuel Tardieu's message of "Tue, 04 Nov 2008 13:42:07 +0100")

Samuel Tardieu <sam@rfc1149.net> writes:

> If "git tag -d -l -v ..." is called, only "-l" is honored, which is
> arbitrary and wrong.
>
> This patch checks that "git tag" knows in what mode it operates before
> performing any operation.
>
> Signed-Off-By: Samuel Tardieu <sam@rfc1149.net>

s/-Off-B/off-b/;

I think this patch breaks "git tag -a" or "git tag -s", but I didn't try.
Run

	$ git tag -s

with and without your patch.

  parent reply	other threads:[~2008-11-04 22:49 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-11-04 12:42 [PATCH 1/3] tag: Do not allow to call "git tag" in more than one operating mode Samuel Tardieu
2008-11-04 12:42 ` [PATCH 2/3] tag: Check that options are only allowed in the appropriate mode Samuel Tardieu
2008-11-04 12:42 ` [PATCH 3/3] tag: Add more tests about mixing incompatible modes and options Samuel Tardieu
2008-11-04 22:47 ` Junio C Hamano [this message]
2008-11-04 23:11   ` [PATCH 1/3] tag: Do not allow to call "git tag" in more than one operating mode Samuel Tardieu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vej1rqfar.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=sam@rfc1149.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.