All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Michael Loeffler <zvpunry@zvpunry.de>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] git-fetch: do not use "*" for fetching multiple refs
Date: Wed, 06 Dec 2006 10:37:45 -0800	[thread overview]
Message-ID: <7vejrc50qu.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1165429001.993.35.camel@ibook.zvpunry.de> (Michael Loeffler's message of "Wed, 06 Dec 2006 19:16:40 +0100")

Michael Loeffler <zvpunry@zvpunry.de> writes:

>> Just a thought.
> I would prefer the following ways to do this globfetch stuff:
>
> 1.) The original refspec:
>     Pull: refs/heads/master:refs/remotes/origin/master
>
> 2.) The one with "prefix match":
>     Pull: refs/heads/:refs/remotes/origin/
>
> 3.) The one with extended regex:
>     Pull: refs/heads/(.*):refs/remotes/origin/\1

Please, don't do regex when talking about paths.  Uniformly
using fnmatch/glob is less confusing.  I do not see anything
wrong with Andy's refspec glob we already have.  Although I
agree that the second asterisk in "src/*:dst/*" has a certain
"Huh?" factor to UNIX-trained eyes, I think it is quite obvious
even to new people what it does.

Also, while I agree that (2) is logical and less typing, I would
avoid cases where foo and foo/ behave differently when "foo"
itself is a directory/tree like thing.  Doing otherwise easily
invites mistakes.


  parent reply	other threads:[~2006-12-06 18:37 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-04 19:38 [PATCH 2/3] git-fetch: do not use "*" for fetching multiple refs Michael Loeffler
2006-12-04 19:48 ` Jakub Narebski
2006-12-06 16:34   ` Michael Loeffler
2006-12-06 16:58     ` Jakub Narebski
2006-12-06 18:16       ` Michael Loeffler
2006-12-06 18:27         ` Jakub Narebski
2006-12-06 18:39           ` Junio C Hamano
2006-12-06 18:37         ` Junio C Hamano [this message]
2006-12-06 23:21       ` Johannes Schindelin
2006-12-06 23:38         ` Jakub Narebski
2006-12-04 19:49 ` Michael Loeffler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vejrc50qu.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=zvpunry@zvpunry.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.