From: Junio C Hamano <junkio@cox.net>
To: Linus Torvalds <torvalds@osdl.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] diff-cache path restriction fix.
Date: Tue, 24 May 2005 18:05:42 -0700 [thread overview]
Message-ID: <7vekbwru6x.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <Pine.LNX.4.58.0505241757280.2307@ppc970.osdl.org> (Linus Torvalds's message of "Tue, 24 May 2005 18:00:54 -0700 (PDT)")
>>>>> "LT" == Linus Torvalds <torvalds@osdl.org> writes:
LT> No, it's more broken than that.
I'll take a look at this later and submit an update, but an OT
point I feel I should address.
LT> Btw, that "1 < argc" order is very unintuitive to most humans.
Yeah? Not to people around where I come from, I do not know
why. It is not done for the assignment confusion avoidance
"1==a".
The comparison lists things in the ascending order from left to
right. The fact that 1 comes before argc on that line of code
visually makes it obvious that I am talking about argc being
larger than one and that is the reason. I'd write (argc < 4)
not (4 > argc) for the same reason.
next prev parent reply other threads:[~2005-05-25 1:04 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-05-25 0:47 [PATCH] diff-cache path restriction fix Junio C Hamano
2005-05-25 1:00 ` Linus Torvalds
2005-05-25 1:05 ` Junio C Hamano [this message]
2005-05-25 1:24 ` Linus Torvalds
2005-05-25 1:49 ` Junio C Hamano
2005-05-25 2:16 ` Russ Allbery
2005-05-25 2:33 ` Junio C Hamano
2005-05-25 3:04 ` Linus Torvalds
2005-05-25 3:22 ` Junio C Hamano
2005-05-25 9:06 ` Ingo Molnar
2005-05-25 17:07 ` Linus Torvalds
2005-05-25 19:14 ` Junio C Hamano
2005-05-25 19:17 ` Thomas Glanzmann
2005-05-25 20:31 ` Matthias Urlichs
2005-05-28 7:55 ` [OT] if (4 < number_of_children) you're in trouble Junio C Hamano
2005-05-25 8:31 ` [PATCH] diff-cache path restriction fix Ingo Molnar
2005-05-25 16:02 ` Florian Weimer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vekbwru6x.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.