From: Junio C Hamano <gitster@pobox.com>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Felipe Contreras <felipe.contreras@gmail.com>,
git@vger.kernel.org, Neil Horman <nhorman@tuxdriver.com>,
Christian Couder <chriscool@tuxfamily.org>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 4/5] test: improve rebase -q test
Date: Tue, 28 May 2013 10:28:46 -0700 [thread overview]
Message-ID: <7vfvx710a9.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130528171907.GA28153@google.com> (Jonathan Nieder's message of "Tue, 28 May 2013 10:19:07 -0700")
Jonathan Nieder <jrnieder@gmail.com> writes:
> Junio C Hamano wrote:
>
>> A more preferrable alternative may be adding something like this to
>> test-lib.sh and call it from here and elsewhere (there are about 50
>> places that do "test ! -s <filename>"), perhaps?
>>
>> test_must_be_an_empty_file () {
>> if test -s "$1"
>> then
>> cat "$1"
>> false
>> fi
>> }
>
> I generally just use the two-liner
>
> >empty &&
> test_cmp empty output
>
> directly in cases like this.
That would work, too.
next prev parent reply other threads:[~2013-05-28 17:28 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-05-28 12:54 [PATCH 0/5] Trivial patches Felipe Contreras
2013-05-28 12:54 ` [PATCH 1/5] remote: trivial style cleanup Felipe Contreras
2013-05-28 17:04 ` Junio C Hamano
2013-05-28 12:54 ` [PATCH 2/5] sequencer: trivial fix Felipe Contreras
2013-05-28 12:54 ` [PATCH 3/5] test: trivial cleanups Felipe Contreras
2013-05-28 12:54 ` [PATCH 4/5] test: improve rebase -q test Felipe Contreras
2013-05-28 17:05 ` Junio C Hamano
2013-05-28 17:19 ` Jonathan Nieder
2013-05-28 17:28 ` Junio C Hamano [this message]
2013-05-29 2:38 ` Felipe Contreras
2013-05-29 16:52 ` Junio C Hamano
2013-05-29 17:11 ` Felipe Contreras
2013-05-28 12:54 ` [PATCH 5/5] test: rebase: fix --interactive test Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfvx710a9.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=artagnon@gmail.com \
--cc=chriscool@tuxfamily.org \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=jrnieder@gmail.com \
--cc=nhorman@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.