All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: Alexey Borzenkov <snaury@gmail.com>,
	Marius Storm-Olsen <mstormo@gmail.com>,
	 git@vger.kernel.org, Johannes.Schindelin@gmx.de,
	 msysgit@googlegroups.com, gitster@pobox.com,  j6t@kdbg.org,
	 lznuaa@gmail.com, raa.lkml@gmail.com,
	Marius Storm-Olsen <marius.storm-olsen@nokia.com>
Subject: Re: [PATCH 04/15] Set _O_BINARY as default fmode for both MinGW and MSVC
Date: Thu, 17 Sep 2009 00:25:33 -0700	[thread overview]
Message-ID: <7vfxamjamq.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4AB1E118.70504@viscovery.net> (Johannes Sixt's message of "Thu\, 17 Sep 2009 09\:11\:20 +0200")


Johannes Sixt <j.sixt@viscovery.net> writes:

> Just for the records: The reason why including git-compat-util.h was not
> necessary before 04/15 is that test-genrandom is linked against libgit.a.
> This way the startup code had picked up the definition of _CRT_fmode from
> mingw.c that is initialized to _O_BINARY. After the original 04/15 this
> symbol was not present anymore in libgit.a, and the default (text mode)
> was used. And with this fix, main() is overridden to explicitly set the
> mode of stdout to _O_BINARY.

Beautiful.  I think it is worth mentioning some of the above in the commit
log message.

Thanks.

  reply	other threads:[~2009-09-17  7:26 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16  8:20 [PATCH v4 00/15] Build Git with MSVC Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 01/15] Avoid declaration after statement Marius Storm-Olsen
2009-09-23  9:44   ` Sebastian Schuberth
2009-09-25 13:34     ` Erik Faye-Lund
2009-09-16  8:20 ` [PATCH 02/15] Add define guards to compat/win32.h Marius Storm-Olsen
2009-09-16  9:42   ` [msysGit] " Erik Faye-Lund
2009-09-16 10:10     ` Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 03/15] Change regerror() declaration from K&R style to ANSI C (C89) Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 04/15] Set _O_BINARY as default fmode for both MinGW and MSVC Marius Storm-Olsen
2009-09-16 16:14   ` Johannes Sixt
2009-09-16 20:00     ` Alexey Borzenkov
2009-09-17  7:11       ` Johannes Sixt
2009-09-17  7:25         ` Junio C Hamano [this message]
2009-09-17  7:27         ` Marius Storm-Olsen
2009-09-17  7:36           ` Johannes Sixt
2009-09-17  7:53             ` Marius Storm-Olsen
2009-09-17  8:10               ` Johannes Sixt
2009-09-17  8:14                 ` Marius Storm-Olsen
2009-09-17  8:39                 ` Alexey Borzenkov
2009-09-17  8:45                   ` Marius Storm-Olsen
2009-09-17  8:57                     ` Alexey Borzenkov
2009-09-17  9:03                   ` Johannes Sixt
2009-09-17  9:28                     ` Marius Storm-Olsen
2009-09-17 13:02                     ` Alexey Borzenkov
2009-09-17 13:30                       ` Johannes Sixt
2009-09-17  8:02   ` Marius Storm-Olsen
2009-09-17 10:44     ` Johannes Sixt
     [not found]       ` <4AB212FA.9080102@viscovery.netm>
2009-09-17 11:04         ` Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 05/15] Fix __stdcall placement and function prototype Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 06/15] Test for WIN32 instead of __MINGW32_ Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 07/15] Add empty header files for MSVC port Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 08/15] Add MinGW header files to build git with MSVC Marius Storm-Olsen
2009-09-23 10:03   ` Sebastian Schuberth
2009-09-23 11:29     ` Marius Storm-Olsen
2009-09-25  0:18       ` [msysGit] " Frank Li
2009-09-16  8:20 ` [PATCH 09/15] Add platform files for MSVC porting Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 10/15] Make usage of windows.h lean and mean Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 11/15] Define strncasecmp and ftruncate for MSVC Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 12/15] Add MSVC to Makefile Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 13/15] Add README for MSVC build Marius Storm-Olsen
2009-09-16  8:20 ` [PATCH 14/15] Add scripts to generate projects for other buildsystems (MSVC vcproj, QMake) Marius Storm-Olsen
2009-09-17 20:28   ` Johannes Sixt
2009-09-18  6:59     ` Marius Storm-Olsen
2009-09-18  8:21       ` Johannes Sixt
2009-09-23 15:04   ` Sebastian Schuberth
2009-09-23 20:37     ` Johannes Schindelin
2009-09-24  6:05       ` Marius Storm-Olsen
2009-09-16  8:20 ` [RFC 15/15] Tag GIT_VERSION when Git is built with MSVC Marius Storm-Olsen
2009-09-17 20:18   ` Johannes Sixt
2009-09-18  6:44     ` Marius Storm-Olsen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfxamjamq.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=j6t@kdbg.org \
    --cc=lznuaa@gmail.com \
    --cc=marius.storm-olsen@nokia.com \
    --cc=mstormo@gmail.com \
    --cc=msysgit@googlegroups.com \
    --cc=raa.lkml@gmail.com \
    --cc=snaury@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.