From: Junio C Hamano <gitster@pobox.com>
To: Pieter de Bie <pdebie@ai.rug.nl>
Cc: Git Mailinglist <git@vger.kernel.org>,
Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH] git-name-rev: allow --name-only in combination with --stdin
Date: Sat, 02 Aug 2008 11:12:51 -0700 [thread overview]
Message-ID: <7vfxpnmgkc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1217510434-94979-1-git-send-email-pdebie@ai.rug.nl> (Pieter de Bie's message of "Thu, 31 Jul 2008 15:20:34 +0200")
Pieter de Bie <pdebie@ai.rug.nl> writes:
> Or was there a specific reason not to allow this?
The --name-only option to the command was added in 1.5.3 cycle, but the
original focus was only to support describe. I do not see any fundamental
reason to disallow it --- we could even say this is a bug.
I've applied the "split single line processing to a separate function" and
then this patch to 'maint' as a bugfix.
next prev parent reply other threads:[~2008-08-02 18:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-31 13:20 [PATCH] git-name-rev: allow --name-only in combination with --stdin Pieter de Bie
2008-08-01 7:23 ` Junio C Hamano
2008-08-01 10:57 ` Johannes Schindelin
2008-08-01 11:16 ` [PATCH] builtin-name-rev: refactor stdin handling to its own function Pieter de Bie
2008-08-01 19:07 ` Junio C Hamano
2008-08-02 18:12 ` Junio C Hamano [this message]
2008-08-03 13:44 ` [PATCH] git-name-rev: don't use printf without format René Scharfe
2008-08-03 20:44 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxpnmgkc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=Johannes.Schindelin@gmx.de \
--cc=git@vger.kernel.org \
--cc=pdebie@ai.rug.nl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.