From: Junio C Hamano <gitster@pobox.com>
To: Petr Baudis <pasky@suse.cz>
Cc: Jan Nieuwenhuizen <janneke-list@xs4all.nl>, git@vger.kernel.org
Subject: Re: [PATCH] git-svn.perl: Strip ChangeLog bits.
Date: Sat, 02 Aug 2008 10:36:38 -0700 [thread overview]
Message-ID: <7vfxpnnwt5.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080802172742.GT32184@machine.or.cz> (Petr Baudis's message of "Sat, 2 Aug 2008 19:27:42 +0200")
Petr Baudis <pasky@suse.cz> writes:
> Hi!
>
> On Sat, Aug 02, 2008 at 03:42:29PM +0200, Jan Nieuwenhuizen wrote:
>> Signed-off-by: Jan Nieuwenhuizen <Jan Nieuwenhuizen janneke@gnu.org>
>
> Just your email should be within the <> brackets.
>
>> ---
>> git-svn.perl | 11 ++++++++++-
>> 1 files changed, 10 insertions(+), 1 deletions(-)
>
> You forgot to document your option. (And possibly write a testcase.)
I am not sure if this is generic enough to be in git-svn.perl itself, or
perhaps there should be a hook make_log_entry() would call in the form of
some Perl scriptlet given by the user to munge $log_entry{log}, which
would be very specific to each project.
next prev parent reply other threads:[~2008-08-02 17:38 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-02 13:42 [PATCH] git-svn.perl: Strip ChangeLog bits Jan Nieuwenhuizen
2008-08-02 17:27 ` Petr Baudis
2008-08-02 17:36 ` Junio C Hamano [this message]
2008-08-02 18:17 ` Jan Nieuwenhuizen
2008-08-02 21:13 ` Junio C Hamano
2008-08-03 12:07 ` Jan Nieuwenhuizen
2008-08-03 20:45 ` Junio C Hamano
2008-08-04 8:07 ` Jan Nieuwenhuizen
2008-08-04 2:09 ` Eric Wong
2008-08-04 2:45 ` Junio C Hamano
2008-08-04 7:49 ` Jan Nieuwenhuizen
2008-08-04 9:03 ` Eric Wong
2008-08-04 11:30 ` Jan Nieuwenhuizen
2008-08-02 18:21 ` Jan Nieuwenhuizen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfxpnnwt5.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=janneke-list@xs4all.nl \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.