From: Junio C Hamano <junkio@cox.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Make git-branch a builtin
Date: Mon, 23 Oct 2006 16:44:08 -0700 [thread overview]
Message-ID: <7vfydewqbb.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20061023215506.GB8344@spearce.org> (Shawn Pearce's message of "Mon, 23 Oct 2006 17:55:06 -0400")
Shawn Pearce <spearce@spearce.org> writes:
> Lars Hjemli <hjemli@gmail.com> wrote:
> [snip]
>> ---
>> Makefile | 3 +-
>> builtin-branch.c | 217 ++++++++++++++++++++++++++++++++++++++++++++++++++++++
>> builtin.h | 1 +
>> git-branch.sh | 131 --------------------------------
>> git.c | 1 +
>> 5 files changed, 221 insertions(+), 132 deletions(-)
> [snip]
>> diff --git a/git-branch.sh b/git-branch.sh
>> deleted file mode 100755
>> index 4379a07..0000000
>> --- a/git-branch.sh
>> +++ /dev/null
>> @@ -1,131 +0,0 @@
> [snip 131 lines]
>
> Aside from compatability with non-Git tools...
>
> Wouldn't it make more sense to just include the full SHA1 of the
> file we are deleting rather than the entire 131 line negative diff?
How would you do "git apply -R" on something like that?
next prev parent reply other threads:[~2006-10-23 23:44 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-23 21:40 [PATCH] Make git-branch a builtin Lars Hjemli
2006-10-23 21:55 ` Shawn Pearce
2006-10-23 23:19 ` Petr Baudis
2006-10-23 23:44 ` Junio C Hamano [this message]
2006-10-24 5:44 ` Shawn Pearce
2006-10-24 6:43 ` Junio C Hamano
2006-10-24 6:55 ` Shawn Pearce
2006-10-24 11:39 ` Petr Baudis
2006-10-24 17:00 ` Junio C Hamano
2006-10-23 22:34 ` Junio C Hamano
2006-10-23 23:51 ` [PATCH] Git-branch: fix regression and style issues Lars Hjemli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vfydewqbb.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.