All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 5/7] gitweb: Added parse_difftree_raw_line function for later use
Date: Thu, 17 Aug 2006 02:55:51 -0700	[thread overview]
Message-ID: <7vfyfvsn2w.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11558064893592-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Thu, 17 Aug 2006 11:21:26 +0200")

Jakub Narebski <jnareb@gmail.com> writes:

> +sub parse_difftree_raw_line {
> +	my $line = shift;
> +	my %res;
> +
> +	# ':100644 100644 03b218260e99b78c6df0ed378e59ed9205ccc96d 3b93d5e7cc7f7dd4ebed13a5cc1a4ad976fc94d8 M	ls-files.c'
> +	# ':100644 100644 7f9281985086971d3877aca27704f2aaf9c448ce bc190ebc71bbd923f2b728e505408f5e54bd073a M	rev-tree.c'
> +	if ($line =~ m/^:([0-7]{6}) ([0-7]{6}) ([0-9a-fA-F]{40}) ([0-9a-fA-F]{40}) (.)([0-9]{0,3})\t(.*)$/) {

We would probably want to say that status symbol is an uppercase
alpha [A-Z].  Or maybe limit it to a non-whitespace letter (\S).
Dot there to say "just any letter" looks wrong.

I would use "+" instead of hardcoding the length of mode strings
(you have 6 there) and object name hash (ditto 40) but that is
mostly style and a slight future proofing against us using
longer hashes (not in our immediate future though).

  reply	other threads:[~2006-08-17  9:55 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-08-17  9:21 [PATCH 0/7] A few gitweb cleanups and improvements Jakub Narebski
2006-08-17  9:21 ` [PATCH 1/7] gitweb: Add support for per project git URLs Jakub Narebski
2006-08-17 18:58   ` David Rientjes
2006-08-17  9:21 ` [PATCH 2/7] gitweb: Refactor printing commit message Jakub Narebski
2006-08-17  9:21 ` [PATCH 3/7] gitweb: Fix typo in separation of git_difftree_body Jakub Narebski
2006-08-17  9:21 ` [PATCH 4/7] gitweb: Expand href() function to use key as param name for no mapping Jakub Narebski
2006-08-17  9:58   ` Junio C Hamano
2006-08-17 10:08     ` Jakub Narebski
2006-08-17  9:21 ` [PATCH 5/7] gitweb: Added parse_difftree_raw_line function for later use Jakub Narebski
2006-08-17  9:55   ` Junio C Hamano [this message]
2006-08-17  9:21 ` [PATCH 6/7] gitweb: Sort query string parameters in href() function Jakub Narebski
2006-08-17  9:21 ` [PATCH 7/7] gitweb: Uniquify version info output, add meta generator in page header Jakub Narebski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfyfvsn2w.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.