All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Patrick Mauritz <oxygene@studentenbude.ath.cx>
Cc: git@vger.kernel.org
Subject: Re: [PATCHES] CURLDIR support, more usable cmd-rename.sh
Date: Mon, 19 Sep 2005 23:25:52 -0700	[thread overview]
Message-ID: <7vfys08dcf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <1127151642.781.15.camel@divert> (Patrick Mauritz's message of "Mon, 19 Sep 2005 19:40:42 +0200")

Patrick Mauritz <oxygene@studentenbude.ath.cx> writes:

>> Not relevant to the current topic as far as I can tell (unless
>> your non-standard curl include files trip under -Wall).
> the only issue with this is that sunpro's cc doesn't like -Wall

Since you will be saying "make CURLDIR=blah" anyway, I'd ask you
to say "make CURLDIR=blah CFLAGS='-O -g'" and will forget about
this part.

The rest of your patch I am keeping a variant based on it, done
slightly differently, in the proposed updates branch.  I'll have
it graduate to the master branch when I hear from somebody (can
be you) with SunPro that the it is OK (or an improvement patch).

Thanks.

      reply	other threads:[~2005-09-20  6:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-09-19 11:14 [PATCHES] CURLDIR support, more usable cmd-rename.sh Patrick Mauritz
2005-09-19 13:37 ` Petr Baudis
2005-09-19 14:11   ` Patrick Mauritz
2005-09-19 14:37     ` Matthias Urlichs
2005-09-19 16:34     ` Junio C Hamano
2005-09-19 17:40       ` Patrick Mauritz
2005-09-20  6:25         ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vfys08dcf.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=oxygene@studentenbude.ath.cx \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.