From: Junio C Hamano <gitster@pobox.com>
To: Nguyen Thai Ngoc Duy <pclouds@gmail.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Jonathon Mah <me@jonathonmah.com>
Subject: Re: [PATCH] cache-tree: invalidate i-t-a paths after writing trees
Date: Thu, 29 Nov 2012 16:06:51 -0800 [thread overview]
Message-ID: <7vhao8neck.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <CACsJy8DEwpg0gY1o6gSB747W5fAYYxz97e-qnkQthSut3B7Eag@mail.gmail.com> (Nguyen Thai Ngoc Duy's message of "Sat, 10 Nov 2012 18:04:32 +0700")
Nguyen Thai Ngoc Duy <pclouds@gmail.com> writes:
>> An alternative might be to add a "phoney" bit next to "used" in the
>> cache_tree structure, mark the cache tree as phoney when we skip an
>> entry marked as CE_REMOVE or CE_ITA, and make the postprocessing
>> loop this patch adds aware of that bit, instead of iterating over
>> the index entries; instead, it would recurse the resulting cache
>> tree and invalidate parts of the tree that have subtrees with the
>> "phoney" bit set, or something.
>
> Yeah, that sounds better.
Did anything happen to this topic after this?
next prev parent reply other threads:[~2012-11-30 0:07 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 8:53 Bug: write-tree corrupts intent-to-add index state Jonathon Mah
2012-11-06 12:37 ` Nguyen Thai Ngoc Duy
2012-11-09 11:04 ` [PATCH] cache-tree: invalidate i-t-a paths after writing trees Nguyễn Thái Ngọc Duy
2012-11-09 11:57 ` Junio C Hamano
2012-11-10 11:04 ` Nguyen Thai Ngoc Duy
2012-11-30 0:06 ` Junio C Hamano [this message]
2012-11-30 1:26 ` Nguyen Thai Ngoc Duy
2012-12-08 4:10 ` [PATCH v2] cache-tree: invalidate i-t-a paths after generating trees Nguyễn Thái Ngọc Duy
2012-12-10 6:50 ` Junio C Hamano
2012-12-10 11:53 ` Nguyen Thai Ngoc Duy
2012-12-10 17:22 ` Junio C Hamano
2012-12-13 1:39 ` [PATCH v3 1/2] " Nguyễn Thái Ngọc Duy
2012-12-13 1:39 ` [PATCH v3 2/2] cache-tree: remove dead i-t-a code in verify_cache() Nguyễn Thái Ngọc Duy
2012-12-13 18:34 ` Junio C Hamano
2012-12-13 2:04 ` [PATCH v3 1/2] cache-tree: invalidate i-t-a paths after generating trees Junio C Hamano
2012-12-15 2:52 ` Nguyen Thai Ngoc Duy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhao8neck.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=me@jonathonmah.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.