From: Junio C Hamano <gitster@pobox.com>
To: Krzysztof Mazur <krzysiek@podlesie.net>
Cc: git@vger.kernel.org,
Felipe Contreras <felipe.contreras@gmail.com>,
Andreas Schwab <schwab@linux-m68k.org>,
Felipe Balbi <balbi@ti.com>,
Tomi Valkeinen <tomi.valkeinen@ti.com>
Subject: Re: [PATCH 5/5] git-send-email: allow edit invalid email address
Date: Mon, 26 Nov 2012 14:58:58 -0800 [thread overview]
Message-ID: <7vhaocotsd.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121126173318.GA12101@shrek.podlesie.net> (Krzysztof Mazur's message of "Mon, 26 Nov 2012 18:33:18 +0100")
Krzysztof Mazur <krzysiek@podlesie.net> writes:
>> Not having this new code inside "elsif (/^e/) { }" feels somewhat
>> sloppy, even though it is not *too* bad. Also do we know this
>
> ok, I will fix that.
>
>> function will never be used for addresses other than recipients' (I
>> gave a cursory look to see what is done to the $sender and it does
>> not seem to go through this function, tho)?
>
> Yes, this function is called only from validate_address_just()
> to filter @initial_to, @initial_cc, @bcc_list as early as possible,
> and filter @to and @cc added in each email.
Thanks; when merged to 'pu', this series seems to break t9001. I'll
push the result out with breakages but could you take a look?
Test Summary Report
-------------------
t9001-send-email.sh (Wstat: 256 Tests: 102 Failed: 77)
Failed tests: 4-7, 9-10, 12-13, 15, 17-21, 23-29, 31-33
35, 37, 39, 41, 43, 45, 47, 49, 51-58, 61-88
91, 93-95, 98-102
Non-zero exit status: 1
next prev parent reply other threads:[~2012-11-26 22:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-19 9:57 Failure to extra stable@vger.kernel.org addresses Felipe Balbi
2012-11-19 15:18 ` Krzysztof Mazur
2012-11-19 15:37 ` Felipe Balbi
2012-11-19 19:27 ` Junio C Hamano
2012-11-19 21:59 ` Felipe Contreras
2012-11-19 22:58 ` Krzysztof Mazur
2012-11-19 23:12 ` Felipe Contreras
2012-11-19 23:57 ` Junio C Hamano
2012-11-20 7:31 ` Krzysztof Mazur
2012-11-20 7:56 ` Krzysztof Mazur
2012-11-20 10:28 ` Felipe Contreras
2012-11-20 11:08 ` Andreas Ericsson
2012-11-20 11:59 ` Krzysztof Mazur
2012-11-20 19:58 ` Andreas Schwab
2012-11-20 21:21 ` Krzysztof Mazur
2012-11-20 22:06 ` Felipe Contreras
2012-11-20 22:30 ` Junio C Hamano
2012-11-20 23:09 ` Krzysztof Mazur
2012-11-20 23:43 ` Junio C Hamano
2012-11-22 18:12 ` [PATCH 1/5] git-send-email: remove garbage after email address Krzysztof Mazur
2012-11-22 18:12 ` [PATCH 2/5] git-send-email: fix fallback code in extract_valid_address() Krzysztof Mazur
2012-11-22 18:12 ` [PATCH 3/5] git-send-email: remove invalid addresses earlier Krzysztof Mazur
2012-11-26 17:02 ` Junio C Hamano
2012-11-22 18:12 ` [PATCH 4/5] git-send-email: ask what to do with an invalid email address Krzysztof Mazur
2012-11-22 18:12 ` [PATCH 5/5] git-send-email: allow edit " Krzysztof Mazur
2012-11-26 17:08 ` Junio C Hamano
2012-11-26 17:33 ` Krzysztof Mazur
2012-11-26 22:58 ` Junio C Hamano [this message]
2012-11-26 23:33 ` Krzysztof Mazur
2012-11-26 23:50 ` Junio C Hamano
2012-11-27 10:53 ` Krzysztof Mazur
2012-11-20 0:00 ` Failure to extra stable@vger.kernel.org addresses Junio C Hamano
2012-11-20 7:15 ` Krzysztof Mazur
2012-11-20 7:54 ` Felipe Balbi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhaocotsd.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=balbi@ti.com \
--cc=felipe.contreras@gmail.com \
--cc=git@vger.kernel.org \
--cc=krzysiek@podlesie.net \
--cc=schwab@linux-m68k.org \
--cc=tomi.valkeinen@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.