From: Junio C Hamano <gitster@pobox.com>
To: Michael Grubb <devel@dailyvoid.com>
Cc: git@vger.kernel.org, vmiklos@frugalware.org, deskinm@umich.edu,
gitster@pobox.com
Subject: Re: [PATCH] Add default merge options for all branches
Date: Mon, 02 May 2011 11:23:07 -0700 [thread overview]
Message-ID: <7vhb9dm06s.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4DBED99E.3050709@dailyvoid.com> (Michael Grubb's message of "Mon, 02 May 2011 11:19:42 -0500")
Michael Grubb <devel@dailyvoid.com> writes:
> The approach taken is to make note of whether a branch specific
> mergeoptions key has been seen and only apply the global value if it
> hasn't. An alternative method would be to keep the
> branch.<branch>.mergeoptions semantics, but assign a special value for
> <branch> to be the global default.
Both my gut feeling and design taste tell me that "branch.*.mergeoptions"
(using literal '*' for match-all for now) would be a lot more appropriate
here. We could extend the '*' part later to take globs.
The resulting part of the configuration file would look like this:
[branch "*"]
mergeoptions = ...
and later we would end up supporting other kinds of defaults, like:
[branch "ko/*"]
remote = korg
[branch "github/*"]
remote = github
mergeoptions = ...
I didn't read the patch carefully but there seems to be many instances of
the same "excess whitespace" pattern you should be able to avoid easily to
match the style by looking at the surrounding code.
Thanks.
prev parent reply other threads:[~2011-05-02 18:23 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-05-02 16:19 [PATCH] Add default merge options for all branches Michael Grubb
2011-05-02 18:12 ` Thiago Farina
2011-05-02 18:22 ` Michael Grubb
2011-05-02 18:40 ` Junio C Hamano
2011-05-02 18:23 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhb9dm06s.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=deskinm@umich.edu \
--cc=devel@dailyvoid.com \
--cc=git@vger.kernel.org \
--cc=vmiklos@frugalware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.