From: Junio C Hamano <gitster@pobox.com>
To: Nanako Shiraishi <nanako3@lavabit.com>
Cc: "Alex Riesen" <raa.lkml@gmail.com>,
"Mark Levedahl" <mlevedahl@gmail.com>,
spearce@spearce.org, dpotapov@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] Only update the cygwin-related configuration during state auto-setup
Date: Mon, 27 Oct 2008 20:27:23 -0700 [thread overview]
Message-ID: <7vhc6xh010.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081027192018.6117@nanako3.lavabit.com> (Nanako Shiraishi's message of "Mon, 27 Oct 2008 19:20:18 +0900")
Nanako Shiraishi <nanako3@lavabit.com> writes:
> Quoting Junio C Hamano <gitster@pobox.com>:
>
>> This is the answer to the question I asked in:
>>
>> http://thread.gmane.org/gmane.comp.version-control.git/97986/focus=98066
>>
>> Perhaps we should use a separate variable as the original patch did, in:
>>
>> http://article.gmane.org/gmane.comp.version-control.git/97987
>>
>> How about doing it like this instead?
>
> Junio, may I ask what the status of this patch is? I see you did not write tests nor commit message --- are you waiting for others to write them?
Heh, Alex's ack is good enough for me as far as the code itself is
concerned, but I do want these "fixes" accompanied by additional tests to
reproduce to avoid future regressions, and this being a Cygwin fix, I am
not really the right person to write tests nor run them.
next prev parent reply other threads:[~2008-10-28 3:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-23 13:07 [PATCH] Only update the cygwin-related configuration during state auto-setup Alex Riesen
2008-10-23 18:36 ` Alex Riesen
2008-10-24 5:54 ` Junio C Hamano
2008-10-24 7:47 ` Alex Riesen
2008-10-27 10:20 ` Nanako Shiraishi
2008-10-28 3:27 ` Junio C Hamano [this message]
2008-10-28 12:21 ` Alex Riesen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhc6xh010.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=dpotapov@gmail.com \
--cc=git@vger.kernel.org \
--cc=mlevedahl@gmail.com \
--cc=nanako3@lavabit.com \
--cc=raa.lkml@gmail.com \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.