All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Peter Valdemar Mørch" <4ux6as402@sneakemail.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Avoid warning when From: is encoded
Date: Fri, 25 Jul 2008 09:33:56 -0700	[thread overview]
Message-ID: <7vhcadudmz.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 1216991208-18782-1-git-send-email-4ux6as402@sneakemail.com

Peter Valdemar Mørch  <4ux6as402@sneakemail.com> writes:

> From: Peter Valdemar Mørch <peter@morch.com>
>
> In commit 0706bd19ef9b41e7519df2c73796ef93484272fd $1 is used from a regexp
> without using () to set up $1. Later, when that value was used, it caused a
> warning about a variable being undefined.
>
> Signed-off-by: Peter Valdemar Mørch <peter@morch.com>

Thanks.  The patch is obviously correct; I think you are fixing 8291db6
(git-send-email: add charset header if we add encoded 'From', 2007-11-16),
not 0706bd1 (send-email: specify content-type of --compose body,
2008-03-28).

Will apply to maint and merge upwards.

  parent reply	other threads:[~2008-07-25 16:35 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-25 13:06 [PATCH] Avoid warning when From: is encoded Peter Valdemar Mørch
2008-07-25 13:16 ` Abhijit Menon-Sen
2008-07-25 16:01   ` Sverre Rabbelier
2008-07-25 16:39     ` Jon Loeliger
2008-07-26  2:53       ` Johannes Schindelin
2008-07-25 16:33 ` Junio C Hamano [this message]
2008-07-25 18:38   ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhcadudmz.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=4ux6as402@sneakemail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.