From: Junio C Hamano <junio@pobox.com>
To: drafnel@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com
Subject: Re: [PATCH 2/2] builtin-tag.c: use valid_ident for checking tagger field
Date: Sun, 11 May 2008 11:39:58 -0700 [thread overview]
Message-ID: <7vhcd43csh.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 9526336.1210309346451.JavaMail.teamon@b304.teamon.com
drafnel@gmail.com writes:
> From: Brandon Casey <drafnel@gmail.com>
>
> Use valid_ident function for validating the tagger field
> in generated tags rather than a tag specific version.
>
> Also update tests.
>
> Signed-off-by: Brandon Casey <drafnel@gmail.com>
> ---
> builtin-tag.c | 39 +++++----------------------------------
> t/t3800-mktag.sh | 14 +++++++-------
> 2 files changed, 12 insertions(+), 41 deletions(-)
>
> diff --git a/builtin-tag.c b/builtin-tag.c
> index 0f79d47..2dcb795 100644
> --- a/builtin-tag.c
> +++ b/builtin-tag.c
> @@ -339,8 +339,7 @@ static int verify_tag_buffer(const char *buffer, size_t size)
> int typelen;
> char type[20];
Funny.
This [2/2] seems to depend on [3/5] that renames verify_tag to verify_tag_buffer().
What is going on?
next prev parent reply other threads:[~2008-05-11 18:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1210309416-27787-1-git-send-email-author@example.com>
2008-05-09 5:03 ` [PATCH 2/2] builtin-tag.c: use valid_ident for checking tagger field drafnel
2008-05-11 18:39 ` Junio C Hamano [this message]
2008-05-12 15:51 ` Brandon Casey
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vhcd43csh.fsf@gitster.siamese.dyndns.org \
--to=junio@pobox.com \
--cc=drafnel@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.