All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junio@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Kevin Ballard <kevin@sb.org>, Git Mailing List <git@vger.kernel.org>
Subject: Re: To page or not to page
Date: Sun, 11 May 2008 10:15:39 -0700	[thread overview]
Message-ID: <7vhcd469tw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080506055128.GA26311@sigill.intra.peff.net> (Jeff King's message of "Tue, 6 May 2008 01:51:28 -0400")

Jeff King <peff@peff.net> writes:

> So how about this:
>
>  - keep a global use_pager = { 0 (explicit no), 1 (explicit yes), -1
>    (unknown) }
>
>  - if git-foo, lookup config for pager.foo
>
>  - otherwise we have "git [options] foo"; look for -p / --no-pager; if
>    none found, then lookup config for "foo"
>
>  - before proceeding further, "commit" the pager choice by running it
>    (if 1), munging GIT_PAGER=cat (if 0), or doing nothing (if -1)
>
>  - before handling an internal command, if use_pager is -1 and the
>    command defaults to a pager, we run it then
>
> The patch below implements this.
>
> It would be nice to actually defer running the pager until we are about
> to run a git command. I.e., never "commit" to the pager until we are
> actually running an internal command or exec'ing an external command.
> That way it would be safe to make an alias that called "--no-pager"
> (which is currently disallowed).

Ok, I agree that this is a less nice (as you mention ablve) but a workable
compromise with the reality.

  parent reply	other threads:[~2008-05-11 17:16 UTC|newest]

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-05-02  5:41 To page or not to page Kevin Ballard
2008-05-02  5:45 ` Jeff King
2008-05-02  5:56   ` Junio C Hamano
2008-05-02  6:04     ` Kevin Ballard
2008-05-02  6:08       ` Junio C Hamano
2008-05-02 13:47         ` Bart Trojanowski
2008-05-02  9:41       ` Pedro Melo
2008-05-02 16:58         ` Kevin Ballard
2008-05-02 10:34       ` Wincent Colaiuta
2008-05-02 12:36         ` Jeff King
2008-05-02 13:49           ` Pedro Melo
2008-05-02 14:00           ` Aidan Van Dyk
2008-05-02 16:13           ` Wincent Colaiuta
2008-05-02 16:56             ` Kevin Ballard
2008-05-02 18:40               ` Wincent Colaiuta
2008-05-02  6:11     ` Jeff King
2008-05-02  7:53       ` Johannes Schindelin
2008-05-02  6:09   ` Jeff King
2008-05-02  6:19     ` Junio C Hamano
2008-05-02 12:55       ` Jeff King
2008-05-02 18:18         ` Junio C Hamano
2008-05-05 21:59           ` Jeff King
2008-05-06  5:51           ` Jeff King
2008-05-06  5:53             ` Jeff King
2008-05-11 17:15             ` Junio C Hamano [this message]
2008-05-16  4:42             ` Jeff King
2008-05-16  4:51               ` Jeff King
2008-05-16 10:29                 ` Johannes Schindelin
2008-05-02  6:56     ` Jakub Narebski
2008-05-02 12:57       ` Jeff King
2008-05-02 15:36     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhcd469tw.fsf@gitster.siamese.dyndns.org \
    --to=junio@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kevin@sb.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.