All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: "Duncan Mak" <duncan@a-chinaman.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] fix vc git
Date: Thu, 21 Dec 2006 16:52:50 -0800	[thread overview]
Message-ID: <7vhcvo92fx.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 8e745ecf0612210359j3f895521r1fff497a512253d3@mail.gmail.com

"Duncan Mak" <duncan@a-chinaman.com> writes:

> --- a/contrib/emacs/vc-git.el
> +++ b/contrib/emacs/vc-git.el
> @@ -58,7 +58,7 @@
>   (with-temp-buffer
>     (let* ((dir (file-name-directory file))
>            (name (file-relative-name file dir)))
> -      (when dir (cd dir))
> +      (when (file-exists-p dir) (cd dir))
>       (and (ignore-errors (eq 0 (call-process "git" nil '(t nil) nil
> "ls-files" "-c" "-z" "--" name)))
>            (let ((str (buffer-string)))
>              (and (> (length str) (length name))

I wonder what would happen when (file-name-directory file)
returns nil with this change...

  reply	other threads:[~2006-12-22  0:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-12-21 11:25 [PATCH] fix vc git Duncan Mak
2006-12-21 11:32 ` Jakub Narebski
2006-12-21 11:59   ` Duncan Mak
2006-12-22  0:52     ` Junio C Hamano [this message]
2006-12-22  4:11       ` Duncan Mak
2006-12-22  4:54         ` Junio C Hamano
2006-12-22 12:39         ` Alexandre Julliard
2006-12-22 12:51           ` Duncan Mak
2006-12-22 13:56             ` Alexandre Julliard
2006-12-22 15:17               ` Duncan Mak

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vhcvo92fx.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=duncan@a-chinaman.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.