From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Thomas Rast <trast@student.ethz.ch>,
Git Mailing List <git@vger.kernel.org>
Subject: Re: Simplify '--prett=xyz' options
Date: Sat, 15 Aug 2009 13:16:08 -0700 [thread overview]
Message-ID: <7viqgoestz.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LFD.2.01.0908151236250.3162@localhost.localdomain> (Linus Torvalds's message of "Sat\, 15 Aug 2009 12\:50\:49 -0700 \(PDT\)")
Linus Torvalds <torvalds@linux-foundation.org> writes:
> On Sat, 15 Aug 2009, Thomas Rast wrote:
>
>> Granted, it makes it equivalent to --pretty=tformat:foo, but isn't
>> tformat the better choice in many cases?
>
> Not really. Look at what happens with
>
> git log --stat --pretty=format:%s
>
> and then try tformat instead. 'tformat' is broken, as is our current
> --format=%s.
>
> In other words, all of that crud is totally illogical, and our "short
> versions" (--oneline and --format=) were done entirely incorrectly (well,
> --oneline probably has the _right_ semantics, and --pretty=oneline is just
> wrong, but whatever).
If you try that without --stat, i.e.
$ git log -4 --pretty=format:%s | cat -e
$ git log -4 --pretty=tformat:%s | cat -e
I suspect you may then find that --pretty=format (not --pretty=tformat) is
broken.
next prev parent reply other threads:[~2009-08-15 20:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-15 19:01 Simplify '--prett=xyz' options Linus Torvalds
2009-08-15 19:19 ` Thomas Rast
2009-08-15 19:50 ` Linus Torvalds
2009-08-15 20:16 ` Junio C Hamano [this message]
2009-08-15 20:36 ` Linus Torvalds
2009-08-15 21:05 ` Avery Pennarun
2009-08-15 21:29 ` Linus Torvalds
2009-08-15 21:39 ` Linus Torvalds
2009-08-15 20:22 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqgoestz.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.