From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Sitaram Chamarty <sitaramc@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] give exclude mechanism a debug option
Date: Sat, 07 Feb 2009 13:45:44 -0800 [thread overview]
Message-ID: <7viqnludiv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 20090207114444.GB18079@coredump.intra.peff.net
Jeff King <peff@peff.net> writes:
> On Fri, Feb 06, 2009 at 11:38:38PM -0800, Junio C Hamano wrote:
>
>> > 2. If you ask for "foo/bar", and "foo/" is ignored, the
>> > output will show only "foo: exclude: foo". This is an
>> > artifact of the calling interface: you don't ask "is
>> > foo/bar excluded", but rather while recursing through
>> > "foo/" you ask "should I bother even recursing into
>> > foo?". So the exclusion code never even knows that you
>> > might have cared about foo/bar in the first place.
>>
>> I do not see why it is a problem. It exactly is what you want to know,
>> isn't it?
>
> Because I would expect "git check-ignore foo/bar | grep ^foo/bar:" to
> tell me if and how foo/bar is being excluded. But I have to instead
> check for ^foo and ^foo/bar.
Sorry, I do not understand why you need the downstream pipe that filters
using grep to begin with.
Shouldn't "git check-ignore dir/path" talk about the exclude entries that
caused dir/path to be excluded and no other patterns? And if the reason
dir/path is exclude is because there was a higher level entry to exclude
dir/, the output would say so. If there are unrelated exclude entries
that exclude dir's neighbour dir2 or dir/path's neighbour dir/path2, they
do not affect if dir/path is excluded, so check-ignore wouldn't show, no?
next prev parent reply other threads:[~2009-02-07 21:48 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-02-06 9:38 How to find out which gitignore blocks my git-add Gonzo
2009-02-06 19:33 ` Jeff King
2009-02-07 1:33 ` Sitaram Chamarty
2009-02-07 6:42 ` Jeff King
2009-02-07 6:44 ` [PATCH 1/2] refactor exclude handling Jeff King
2009-02-07 6:44 ` [PATCH 2/2] give exclude mechanism a debug option Jeff King
2009-02-07 7:38 ` Junio C Hamano
2009-02-07 7:42 ` Junio C Hamano
2009-02-07 11:46 ` Jeff King
2009-02-07 11:44 ` Jeff King
2009-02-07 21:45 ` Junio C Hamano [this message]
2009-02-08 8:59 ` Jeff King
2009-02-08 9:50 ` Junio C Hamano
2009-02-08 9:52 ` Jeff King
2009-02-07 12:44 ` How to find out which gitignore blocks my git-add Sitaram Chamarty
2009-02-07 13:31 ` Jeff King
2009-02-06 22:00 ` Bisani, Alok
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqnludiv.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
--cc=sitaramc@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.