From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nathan Panike <nathan.panike@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH 0/2] Use %as and %cs as pretty format flags
Date: Thu, 28 Aug 2008 16:36:51 -0700 [thread overview]
Message-ID: <7viqtkd84s.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080828231547.GD29609@coredump.intra.peff.net> (Jeff King's message of "Thu, 28 Aug 2008 19:15:48 -0400")
Jeff King <peff@peff.net> writes:
> On Thu, Aug 28, 2008 at 06:09:37AM -0500, Nathan Panike wrote:
>
>> The patch series below allows git to use %as and %cs as flags for
>> pretty-printing the format of a date.
>
> Your description leaves a little to be desired (here and in the patches
> themselves). I had to read the patch to figure out that these are
> formatting specifiers for the date format "short".
>
> That being said, I think this is probably reasonable just for the sake
> of completeness (and I doubt we are wasting a useful formatting combo,
> since %a* is likely to remain dedicated to author information). I wonder
> if there should be "%al" for "local".
>
> However, it makes me wonder even more if '%ad' should simply respect the
> --date= parameter (this wouldn't allow you to mix and match dates in a
> single format, but I don't think that is what is desired). Or whether we
> should have some syntax for "%ad(short)" or something, where the
> argument would be handed off to the date format parser. But that is
> probably overengineering.
I was actually thinking about rejecting this, asking for something that
allows to express all the other %[ai][dDri] format can express, and
perhaps more. So I think "%ad(short)" is a good direction to go, except
that 'd' is already taken. Perhaps %a(date), %a(shortdate,local),...?
Oh, and before anybody asks, even if we do %a(specifier), you can keep
writing "%ad" if you are used to it. I am not talking about deprecating
the existing ones, but making future extensions easier without forcing
people to remember cryptic one-letter format specifiers.
next prev parent reply other threads:[~2008-08-28 23:38 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-28 11:09 [PATCH 0/2] Use %as and %cs as pretty format flags Nathan Panike
2008-08-28 23:15 ` Jeff King
2008-08-28 23:36 ` Junio C Hamano [this message]
2008-08-28 23:54 ` Jeff King
2008-08-29 0:10 ` Nathan W. Panike
2008-08-29 0:54 ` Jeff King
2008-08-29 1:08 ` Junio C Hamano
2008-08-29 8:12 ` Jakub Narebski
2008-08-29 3:43 ` Avery Pennarun
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7viqtkd84s.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=nathan.panike@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.