From: Junio C Hamano <gitster@pobox.com>
To: Pierre Habouzit <madcoder@debian.org>
Cc: Daniel Barkalow <barkalow@iabervon.org>, git@vger.kernel.org
Subject: Re: [PATCH] Use parseopts in builtin-fetch
Date: Mon, 05 Nov 2007 11:13:33 -0800 [thread overview]
Message-ID: <7vir4gqzdu.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071105085513.GB25574@artemis.corp> (Pierre Habouzit's message of "Mon, 05 Nov 2007 09:55:13 +0100")
Pierre Habouzit <madcoder@debian.org> writes:
> On Mon, Nov 05, 2007 at 03:35:34AM +0000, Daniel Barkalow wrote:
>> I mostly did this and the next one for practice with the API. I'm
>> impressed that "git fetch -vv" is even handled correctly without anything
>> special.
>
> About that: OPTION_BOOLEAN increments the associated variable, to
> support this case specifically.
>
> The last thing that really miss in parse-options is a way to recurse
> into a sub-array of struct option, to be able to port the generic diff
> and revision arguments.
Another micronit is I found lacking is that it is a bit too
cumbersome to accept only a subset of integer as a value
(e.g. "this option takes a positive integer, not zero nor
negative"). The caller can set up a callback to handle that,
though.
next prev parent reply other threads:[~2007-11-05 19:13 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-05 3:35 [PATCH] Use parseopts in builtin-fetch Daniel Barkalow
2007-11-05 8:43 ` Pierre Habouzit
2007-11-05 17:14 ` Daniel Barkalow
2007-11-05 8:55 ` Pierre Habouzit
2007-11-05 17:02 ` Kristian Høgsberg
2007-11-05 17:41 ` Daniel Barkalow
2007-11-05 19:13 ` Junio C Hamano [this message]
2007-11-05 19:48 ` Pierre Habouzit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vir4gqzdu.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=madcoder@debian.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.