From: Junio C Hamano <junkio@cox.net>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Martin Koegler <mkoegler@auto.tuwien.ac.at>
Subject: Re: [PATCH (resend)] gitweb: Support comparing blobs (files) with different names
Date: Fri, 30 Mar 2007 15:56:09 -0700 [thread overview]
Message-ID: <7virciz6gm.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <200703302341.27225.jnareb@gmail.com> (Jakub Narebski's message of "Fri, 30 Mar 2007 23:41:26 +0200")
Jakub Narebski <jnareb@gmail.com> writes:
> Fix the bug that caused "blobdiff" view called with new style URI
> for a rename with change diff to be show as new (added) file diff.
>
> New style URI for "blobdiff" for rename means with $hash_base ('hb') and
> $hash_parent_base ('hpb') paramaters denoting tree-ish (usually commit)
> of a blobs being compared, together with both $file_name ('f') and
> $file_parent ('fp') parameters.
>
> It is done by adding $file_parent ('fp') to the path limiter, meaning
> that diff command becomes:
>
> git diff-tree [options] hpb hb -- fp f
>
> Other option would be finding hash of a blob using git_get_hash_by_path
> subroutine and comparing blobs using git-diff, or using extended SHA-1
> syntax and compare blobs using git-diff:
>
> git diff [options] hpb:fp hp:f
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>
> ---
> Junio, could you apply this? It looks like it was lost in the noise.
I was waiting for dust to settle. Ack's from people involved in
the discussion would be nice.
next prev parent reply other threads:[~2007-03-30 22:56 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-03-30 21:41 [PATCH (resend)] gitweb: Support comparing blobs (files) with different names Jakub Narebski
2007-03-30 22:56 ` Junio C Hamano [this message]
2007-03-30 23:41 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7virciz6gm.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=jnareb@gmail.com \
--cc=mkoegler@auto.tuwien.ac.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.