All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Shawn Pearce <spearce@spearce.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Automatically line wrap long commit messages.
Date: Mon, 29 May 2006 02:16:35 -0700	[thread overview]
Message-ID: <7virnp8a30.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: 20060529085738.GB29500@spearce.org

Shawn Pearce <spearce@spearce.org> writes:

> When using -m on the command line with git-commit it is not uncommon
> for a long commit message to be entered without line terminators.
> This creates commit objects whose messages are not readable in
> 'git log' as the line runs off the screen.
>
> So instead reformat log messages if they are supplied on the
> command line.
>
> Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
> ---
>  This one might cause some problems for people.

I am already moderately negative on multiple -m so in the light
of it this one looks totally unneeded.  You could do a number of
things:

	$ git commit -m 'This is my message.

	This is the first line of the message body.'
        $ cat >L <<EOF
        This is my message.

	This is the first line of the message body.'
	EOF
	$ git commit -F L
	$ fmt <<EOF
        This is my message.

	This is the first line of the message body.'
	EOF
	$ git commit -F L

We probably should allow "commit -F -" to read from the standard
input if we already don't, but that is about as far as I am
willing to go at this moment.

  parent reply	other threads:[~2006-05-29  9:16 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-05-29  8:57 [PATCH] Automatically line wrap long commit messages Shawn Pearce
2006-05-29  9:00 ` Jan-Benedict Glaw
2006-05-29  9:14   ` Shawn Pearce
2006-05-29  9:16 ` Junio C Hamano [this message]
2006-05-29  9:46   ` Shawn Pearce
2006-05-30  8:38     ` Junio C Hamano
2006-05-31  2:18       ` Shawn Pearce
2006-05-31  5:05         ` Junio C Hamano
2006-06-01  3:34           ` Shawn Pearce
2006-06-01  6:37             ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7virnp8a30.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=git@vger.kernel.org \
    --cc=spearce@spearce.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.