From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH] block-sha1: Windows declares ntohl() in winsock2.h Date: Tue, 18 Aug 2009 12:00:42 -0700 Message-ID: <7vk511dk11.fsf@alter.siamese.dyndns.org> References: <4A8A552D.6020407@viscovery.net> <4A8A8661.5060908@gmail.com> <4A8AA511.1060205@gmail.com> <7v4os5gs0p.fsf@alter.siamese.dyndns.org> <7v1vn9f4mz.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Sebastian Schuberth , Artur Skawina , Johannes Sixt , msysGit , Linus Torvalds , Git Mailing List To: Nicolas Pitre X-From: git-owner@vger.kernel.org Tue Aug 18 21:01:02 2009 Return-path: Envelope-to: gcvg-git-2@lo.gmane.org Received: from vger.kernel.org ([209.132.176.167]) by lo.gmane.org with esmtp (Exim 4.50) id 1MdTvY-0005ud-Eg for gcvg-git-2@lo.gmane.org; Tue, 18 Aug 2009 21:01:00 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751206AbZHRTAw (ORCPT ); Tue, 18 Aug 2009 15:00:52 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751018AbZHRTAv (ORCPT ); Tue, 18 Aug 2009 15:00:51 -0400 Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:35400 "EHLO sasl.smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750743AbZHRTAv (ORCPT ); Tue, 18 Aug 2009 15:00:51 -0400 Received: from a-pb-sasl-quonix. (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id 699C1F77A; Tue, 18 Aug 2009 15:00:52 -0400 (EDT) Received: from pobox.com (unknown [68.225.240.211]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 52C4DF776; Tue, 18 Aug 2009 15:00:44 -0400 (EDT) In-Reply-To: (Nicolas Pitre's message of "Tue\, 18 Aug 2009 14\:01\:57 -0400 \(EDT\)") User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.2 (gnu/linux) X-Pobox-Relay-ID: 73549B8E-8C29-11DE-91CF-EAC21EFB4A78-77302942!a-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Nicolas Pitre writes: > On Tue, 18 Aug 2009, Junio C Hamano wrote: > >> For git's own use, I would be much happier with this change. >> >> But given that there are some people wanting to snarf block-sha1/*.[ch] >> out to use them standalone, I have a slight hesitation against introducing >> the dependency to git-compat-util.h, making it unclear to them that all >> this file wants from outside are ntohl, htonl and memcpy. > > Should we really care to keep our code suboptimal just to make it > readily reusable by other projects? That seems a bit backward to me. You are right; and I should give a bit more credit to their intelligence. The source (block-sha1/sha1.c) is short enough that they can figure this out for themselves even without any additional comments. Another issue, especially with your "openssl sha1 removal" patch, is if we can assume gcc everywhere. As far as I can tell, block-sha1/sha1.c will be the first unconditional use of inline asm or statement expression on i386/amd64. Are folks on Solaris and other platforms Ok with this?