All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Christian Couder <chriscool@tuxfamily.org>
Cc: git@vger.kernel.org, Johannes Schindelin <Johannes.Schindelin@gmx.de>
Subject: Re: [PATCH 1/3] list-objects: add "void *data" parameter to show functions
Date: Tue, 07 Apr 2009 22:10:26 -0700	[thread overview]
Message-ID: <7vk55vspbx.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <200904080639.35499.chriscool@tuxfamily.org> (Christian Couder's message of "Wed, 8 Apr 2009 06:39:35 +0200")

Christian Couder <chriscool@tuxfamily.org> writes:

> This is the relevant hunk in patch 2/3:
>
> diff --git a/bisect.h b/bisect.h
> index f5d1067..b1c334d 100644
> --- a/bisect.h
> +++ b/bisect.h
> @@ -14,12 +14,14 @@ extern struct commit_list *filter_skipped(struct 
> commit_list *list,
>  #define BISECT_SHOW_TRIED      (1<<1)
>  #define BISECT_SHOW_STRINGED   (1<<2)
>  
> -/*
> - * The flag BISECT_SHOW_ALL should not be set if this function is called
> - * from outside "builtin-rev-list.c" as otherwise it would use
> - * static "revs" from this file.
> - */

Thanks for a clarification.

      reply	other threads:[~2009-04-08  5:12 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20090407040819.4338.4291.chriscool@tuxfamily.org>
2009-04-06 19:28 ` [PATCH 1/3] list-objects: add "void *data" parameter to show functions Christian Couder
2009-04-06 20:28   ` [PATCH 2/3] rev-list: remove last static vars used in "show_commit" Christian Couder
2009-04-07  3:08     ` [PATCH 3/3] rev-list: add "int bisect_show_flags" in "struct rev_list_info" Christian Couder
2009-04-08  7:40     ` [PATCH 2/3] rev-list: remove last static vars used in "show_commit" Paolo Bonzini
2009-04-09  3:11       ` Christian Couder
2009-04-08  2:29   ` [PATCH 1/3] list-objects: add "void *data" parameter to show functions Junio C Hamano
2009-04-08  4:39     ` Christian Couder
2009-04-08  5:10       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk55vspbx.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=chriscool@tuxfamily.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.