All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <junkio@cox.net>
To: Martin Langhoff <martin@catalyst.net.nz>
Cc: git@vger.kernel.org, Johannes.Schindelin@gmx.de
Subject: Re: [PATCH] cvsimport - streamline temp index file creation and avoid creating empty tmpfiles
Date: Fri, 23 Jun 2006 23:59:28 -0700	[thread overview]
Message-ID: <7vk67711kf.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <11511257501323-git-send-email-martin@catalyst.net.nz> (Martin Langhoff's message of "Sat, 24 Jun 2006 17:09:10 +1200")

Martin Langhoff <martin@catalyst.net.nz> writes:

> On 6/24/06, Johannes Schindelin <Johannes.Schindelin@gmx.de> wrote:
>> It seems that git-cvsimport makes a temporary file of size 0, which cannot
>> get mmap()ed, because it has size 0.
>
> This switch to tmpnam() avoids creating the tmpfile in the first place and
> streamlines the code. This handling of tmpfiles is slightly safer, but there
> is an inherent race condition.
>
> ---
> NOTE: (a) I cannot reproduce the problem and (b) this is only lightly tested,
> if trivial.

Thanks both.

I'd take this to "next" after I hear from somebody, most likely
Johannes, who had trouble with the code earlier that the problem
is fixed.

  reply	other threads:[~2006-06-24  6:59 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-23 16:14 CVS import broken? Johannes Schindelin
2006-06-24  5:09 ` [PATCH] cvsimport - streamline temp index file creation and avoid creating empty tmpfiles Martin Langhoff
2006-06-24  6:59   ` Junio C Hamano [this message]
2006-06-24  9:50   ` Johannes Schindelin
2006-06-24 10:05     ` Junio C Hamano
2006-06-24 11:16       ` Martin Langhoff
2006-06-24 11:28         ` Junio C Hamano
2006-06-24 19:05       ` Johannes Schindelin
2006-06-24 10:08     ` Martin Langhoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vk67711kf.fsf@assigned-by-dhcp.cox.net \
    --to=junkio@cox.net \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=git@vger.kernel.org \
    --cc=martin@catalyst.net.nz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.