From: Junio C Hamano <gitster@pobox.com>
To: Michael Haggerty <mhagger@alum.mit.edu>
Cc: Jeff King <peff@peff.net>, git@vger.kernel.org
Subject: Re: [PATCH v2 2/6] string_list: add two new functions for splitting strings
Date: Mon, 10 Sep 2012 15:00:36 -0700 [thread overview]
Message-ID: <7vlighlerf.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1347311926-5207-3-git-send-email-mhagger@alum.mit.edu> (Michael Haggerty's message of "Mon, 10 Sep 2012 23:18:42 +0200")
Michael Haggerty <mhagger@alum.mit.edu> writes:
> diff --git a/string-list.c b/string-list.c
> index 5594b7d..f9051ec 100644
> --- a/string-list.c
> +++ b/string-list.c
> @@ -204,3 +204,52 @@ void unsorted_string_list_delete_item(struct string_list *list, int i, int free_
> list->items[i] = list->items[list->nr-1];
> list->nr--;
> }
> +
> +int string_list_split(struct string_list *list, const char *string,
> + int delim, int maxsplit)
> +{
> + int count = 0;
> + const char *p = string, *end;
> +
> + assert(list->strdup_strings);
This may be a taste thing, but I'd prefer to see assert() only for
verification of pre-condition by internal callers to catch stupid
programming errors. For a library-ish function like sl_split() that
expects to be called from anybody outside the string-list API, a
violation of this pre-condition is a usage error of the API, and
should trigger a runtime error (even without NDEBUG), no?
next prev parent reply other threads:[~2012-09-10 22:00 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-10 21:18 [PATCH v2 0/6] Add some string_list-related functions Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 1/6] string_list: add function string_list_append_nodup() Michael Haggerty
2012-09-10 21:56 ` Junio C Hamano
2012-09-10 22:03 ` Michael Haggerty
2012-09-12 13:32 ` Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 2/6] string_list: add two new functions for splitting strings Michael Haggerty
2012-09-10 22:00 ` Junio C Hamano [this message]
2012-09-10 22:33 ` Junio C Hamano
2012-09-12 13:12 ` Michael Haggerty
2012-09-12 17:55 ` Junio C Hamano
2012-09-10 21:18 ` [PATCH v2 3/6] string_list: add a new function, filter_string_list() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 4/6] string_list: add a new function, string_list_remove_duplicates() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 5/6] string_list: add a function string_list_longest_prefix() Michael Haggerty
2012-09-10 21:18 ` [PATCH v2 6/6] api-string-list.txt: initialize the string_list the easy way Michael Haggerty
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vlighlerf.fsf@alter.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=mhagger@alum.mit.edu \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.