All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Felipe Contreras <felipec@infradead.org>
Cc: "Jonathan Nieder" <jrnieder@gmail.com>,
	git@vger.kernel.org,
	"Felipe Contreras" <felipe.contreras@gmail.com>,
	"Ted Pavlic" <ted@tedpavlic.com>,
	"SZEDER Gábor" <szeder@ira.uka.de>,
	"Shawn O. Pearce" <spearce@spearce.org>
Subject: Re: [PATCH v2 3/4] completion: cleanup __gitcomp*
Date: Mon, 30 Jan 2012 13:25:59 -0800	[thread overview]
Message-ID: <7vliooanmg.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <7vpqe1au7f.fsf@alter.siamese.dyndns.org> (Junio C. Hamano's message of "Mon, 30 Jan 2012 11:03:48 -0800")

I managed to pick up 1 & 2:

 1. be nicer with zsh (aka avoid default value assignment on : true
    command);

 2. simplify __git_remotes (aka use ls -1 instead of rolling a loop to do
    that ourselves).

But I do not see your patch for 3 & 4 either on gmane archive nor in my
mailbox (via vger, not direct delivery from you to me). The threads for
these two patches both begin with Jonathan's review for me.

Care to resend 3 & 4?

Thanks.

  reply	other threads:[~2012-01-30 21:26 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-01-30 17:23 [PATCH 0/4] completion: trivial cleanups Felipe Contreras
2012-01-30 17:23 ` [PATCH v2 2/4] completion: remove unused code Felipe Contreras
     [not found] ` <1327944197-6379-2-git-send-email-felipec@infradead.org>
2012-01-30 17:34   ` [PATCH v2 1/4] completion: simplify __git_remotes Jonathan Nieder
2012-01-30 18:27     ` Junio C Hamano
     [not found] ` <1327944197-6379-4-git-send-email-felipec@infradead.org>
2012-01-30 17:50   ` [PATCH v2 3/4] completion: cleanup __gitcomp* Jonathan Nieder
2012-01-30 19:03     ` Junio C Hamano
2012-01-30 21:25       ` Junio C Hamano [this message]
2012-01-31  0:15     ` SZEDER Gábor
2012-01-31  0:25       ` Jonathan Nieder
     [not found] ` <1327944197-6379-5-git-send-email-felipec@infradead.org>
2012-01-30 17:53   ` [PATCH v2 4/4] completion: be nicer with zsh Jonathan Nieder
2012-01-30 18:10     ` Felipe Contreras
2012-01-30 18:25       ` Jonathan Nieder
2012-01-30 18:56         ` Felipe Contreras
2012-01-30 19:03           ` Jonathan Nieder
2012-01-30 19:09         ` Junio C Hamano
2012-01-30 19:22           ` Felipe Contreras
2012-01-30 19:28             ` Jonathan Nieder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vliooanmg.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=felipe.contreras@gmail.com \
    --cc=felipec@infradead.org \
    --cc=git@vger.kernel.org \
    --cc=jrnieder@gmail.com \
    --cc=spearce@spearce.org \
    --cc=szeder@ira.uka.de \
    --cc=ted@tedpavlic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.