All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jakub Narebski <jnareb@gmail.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Drew Northup <drew.northup@maine.edu>,
	John 'Warthog9' Hawley <warthog9@kernel.org>,
	Petr Baudis <pasky@suse.cz>
Subject: Re: [PATCH 1/2] gitweb: Refactor reading and parsing config file into read_config_file
Date: Wed, 25 May 2011 12:36:35 -0700	[thread overview]
Message-ID: <7vmxia373w.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <1306341328-11108-2-git-send-email-jnareb@gmail.com> (Jakub Narebski's message of "Wed, 25 May 2011 18:35:26 +0200")

Jakub Narebski <jnareb@gmail.com> writes:

> Beside being obvious reduction of duplicated code, this is enables us
> to easily call site-wide config file in per-installation config file.
>
> The actual update to documentation is left for next commit, because of
> possible exclusive alternative (possible other next commit) of always
> reading system-wide config file and relying on per-instalation config
> file overriding system-wide defaults.
>
> Signed-off-by: Jakub Narebski <jnareb@gmail.com>

As John acked this one and it looks obviously the right thing to do to me,
I'll apply this one directly to "master".

Thanks.

  reply	other threads:[~2011-05-25 19:36 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-05-25 16:35 [PATCH 0/2] gitweb: Improve handling of configuration files Jakub Narebski
2011-05-25 16:35 ` [PATCH 1/2] gitweb: Refactor reading and parsing config file into read_config_file Jakub Narebski
2011-05-25 19:36   ` Junio C Hamano [this message]
2011-05-25 16:35 ` [PATCHv1 2/2 (version A)] gitweb: Mention read_config_file in gitweb/README Jakub Narebski
2011-05-25 16:35 ` [PATCHv3 2/2 (version B)] gitweb: Use /etc/gitweb.conf even if gitweb_conf.perl exist Jakub Narebski
2011-05-25 18:54   ` Junio C Hamano
2011-05-26 14:58     ` [PATCH/RFC 2/2 (version C)] gitweb: Introduce common system-wide settings for convenience Jakub Narebski
2011-05-25 18:38 ` [PATCH 0/2] gitweb: Improve handling of configuration files J.H.
2011-05-25 19:34   ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmxia373w.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=drew.northup@maine.edu \
    --cc=git@vger.kernel.org \
    --cc=jnareb@gmail.com \
    --cc=pasky@suse.cz \
    --cc=warthog9@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.