All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jay Soffian <jaysoffian@gmail.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Confused about diff-tree --cc output
Date: Thu, 05 Feb 2009 00:38:24 -0800	[thread overview]
Message-ID: <7vmyd1ffcv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: 76718490902041949v8fffd17l7cb19d836a3e1887@mail.gmail.com

Jay Soffian <jaysoffian@gmail.com> writes:

> Is that about right?

Yes, not just about right but it is how it works.

The patch in:

    http://article.gmane.org/gmane.comp.version-control.git/15500

gave the final implementation of the rule.

The rule is that if there are only one or two variations to choose from,
and the result matches one of them, it is not interesting.  Otherwise it
is interesting.

In an octopus where more than two parents disagree, no matter what the
result is, it is interesting.

In an extreme case, even if both parents in a two-parent merge had the
same contents (i.e. only one to choose from), if you amend the merge
result to make it different from it, it becomes interesting.

In your example, two pieces, each of which took everything from one parent
(hence is uninteresting by itself), happened to lie within the context
range.  It is not very interesting, and it automerges cleanly, but it is
rare that these merges happen close together, and that "close miss" is
what makes this case "interesting".

It is exactly the same as the example in the message I referred you to.
In the same thread:

    http://article.gmane.org/gmane.comp.version-control.git/15598

has a very clear explanation about this exact kind of borderline "is it
really interesting?" case.

Also the follow-up to it:

    http://article.gmane.org/gmane.comp.version-control.git/15600

would give you further insights, the most interesting of which is that
what is shown in --cc output does *NOT* have anything to do with "did the
merge result in a manual conflict resolution?"

By the way, the latter message talks about gitk not showing the right
thing, but that was an ancient story.  These days gitk just shows what
diff --cc feeds it and there is no discrepancy between the two.

  reply	other threads:[~2009-02-05  8:40 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-04 21:13 Confused about diff-tree --cc output Jay Soffian
2009-02-04 21:56 ` Junio C Hamano
2009-02-05  3:49   ` Jay Soffian
2009-02-05  8:38     ` Junio C Hamano [this message]
2009-02-05  8:57       ` Jay Soffian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmyd1ffcv.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=jaysoffian@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.