All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Kelvie Wong" <kelvie@ieee.org>
Cc: git@vger.kernel.org
Subject: Re: Mergetool generating blank files (1.5.3)
Date: Thu, 27 Sep 2007 14:33:48 -0700	[thread overview]
Message-ID: <7vmyv7sshv.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <94ccbe710709271422x5d1739c2g5da961c88a4336fe@mail.gmail.com> (Kelvie Wong's message of "Thu, 27 Sep 2007 14:22:41 -0700")

"Kelvie Wong" <kelvie@ieee.org> writes:

>> > It _could_ be just the matter of doing this, although I cannot
>> > test it right now (at work and have no access to any of the
>> > backends).  Care to try it from a subdirectory and report
>> > failure or success?

Actually, it seems that mergetool can take paths arguments, and
they need to be adjusted, so here is a fixed patch.

---
 git-mergetool.sh |    4 +++-
 1 files changed, 3 insertions(+), 1 deletions(-)

diff --git a/git-mergetool.sh b/git-mergetool.sh
index a0e44f7..56ec993 100755
--- a/git-mergetool.sh
+++ b/git-mergetool.sh
@@ -12,6 +12,8 @@ USAGE='[--tool=tool] [file to merge] ...'
 SUBDIRECTORY_OK=Yes
 . git-sh-setup
 require_work_tree
+directory_prefix=$(git rev-parse --show-prefix)
+cd_to_toplevel
 
 # Returns true if the mode reflects a symlink
 is_symlink () {
@@ -378,7 +380,7 @@ if test $# -eq 0 ; then
 else
 	while test $# -gt 0; do
 		printf "\n"
-		merge_file "$1"
+		merge_file "$directory_prefix$1"
 		shift
 	done
 fi

  reply	other threads:[~2007-09-27 21:34 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-09-27 18:31 Mergetool generating blank files (1.5.3) Kelvie Wong
2007-09-27 18:57 ` Pierre Habouzit
2007-09-27 19:00   ` Russ Brown
2007-09-27 19:11     ` Pierre Habouzit
2007-09-27 22:23       ` Theodore Tso
2007-09-27 22:28         ` Pierre Habouzit
2007-09-28  5:15           ` Peter Baumann
2007-09-28  6:35             ` Pierre Habouzit
2007-09-27 19:12   ` Jeff King
2007-09-27 19:16     ` Pierre Habouzit
2007-09-27 19:41       ` Jeff King
2007-09-27 19:24   ` Kelvie Wong
2007-09-27 19:58     ` Junio C Hamano
2007-09-27 20:12       ` Kelvie Wong
2007-09-27 20:28         ` Junio C Hamano
2007-09-27 20:38           ` Kelvie Wong
2007-09-27 20:47             ` Junio C Hamano
2007-09-27 20:51               ` Junio C Hamano
2007-09-27 21:17                 ` Kelvie Wong
2007-09-27 21:22                   ` Kelvie Wong
2007-09-27 21:33                     ` Junio C Hamano [this message]
2007-09-27 21:41                       ` Junio C Hamano
2007-09-27 22:23                         ` Kelvie Wong
2007-09-27 22:52                           ` Theodore Tso
2007-09-28  4:17                             ` Kelvie Wong
2007-09-28  6:19                               ` David Kastrup
2007-09-27 22:35                         ` Theodore Tso
2007-09-28  8:43     ` David Kågedal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vmyv7sshv.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=kelvie@ieee.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.