From: Junio C Hamano <junkio@cox.net>
To: Paul Mackerras <paulus@samba.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] Provide a way to flush git-diff-tree's output
Date: Thu, 18 May 2006 00:24:14 -0700 [thread overview]
Message-ID: <7vmzdf6bj5.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <17516.6955.282732.460675@cargo.ozlabs.ibm.com> (Paul Mackerras's message of "Thu, 18 May 2006 16:58:51 +1000")
Paul Mackerras <paulus@samba.org> writes:
> The --stdin flag to git-diff-tree is suitable for this, but the main
> difficulty is that the output of git-diff-tree gets buffered and
> doesn't get sent until the buffer is full.
>
> This provides a way to get git-diff-tree to flush its output buffers.
> If a blank line is supplied on git-diff-tree's standard input, it will
> flush its output buffers and then accept further input.
Sounds low impact and sane.
I suspect the usual caveat on bidirectional pipe deadlock
applies to the caller. Does gitk do that? The current code
seems to feed a pre-generated list with "open | cmd <<"
construct to the command, so perhaps you are planning to change
that?
next prev parent reply other threads:[~2006-05-18 7:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-18 6:58 [PATCH] Provide a way to flush git-diff-tree's output Paul Mackerras
2006-05-18 7:24 ` Junio C Hamano [this message]
2006-05-18 9:43 ` Paul Mackerras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vmzdf6bj5.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=paulus@samba.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.