All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: Alexander Nestorov <alexandernst@gmail.com>, git <git@vger.kernel.org>
Subject: Re: [Request] Git reset should be able to ignore file permissions
Date: Wed, 19 Jun 2013 11:43:30 -0700	[thread overview]
Message-ID: <7vobb2ym99.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <vpqfvwel4bi.fsf@anie.imag.fr> (Matthieu Moy's message of "Wed, 19 Jun 2013 13:37:05 +0200")

Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:

> Alexander Nestorov <alexandernst@gmail.com> writes:
>
>> Ok, this is how it looks. If everything is ok, I'm sending it to the ML
>
> Please, read Documentation/SubmittingPatches (you lack a sign-off and if
> you think the patch is ready, you should Cc Junio). Also, it's better to
> have the commit headers directly as mail headers (git send-email is your
> friend).
>
>> +Reset only files who's content changed (instead of stat information)::
>
> That's still not 100% accurate. Actual mode changes would trigger a
> rewrite of the file. Perhaps stg like
>
> Reset only files which actually changed (not those with only stat information change)::
>
> (Sorry for nitpicking so much)

I do not think the above clarifies anything to be of much help.

If you _know_ what "actually changed" means, i.e. either contents or
the executable-ness changed, then "(not those ...)" does not help
you at all.

If you don't, then "only stat information change" will invite "I did
chmod -x and the file does not have any actual change." confusion.

If this addition is to help people who do not know what "actually
changed" means, that part needs to be clarified, no?

  reply	other threads:[~2013-06-19 18:43 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-18 13:25 [Request] Git reset should be able to ignore file permissions Alexander Nestorov
2013-06-18 13:34 ` Matthieu Moy
2013-06-18 13:48   ` Alexander Nestorov
2013-06-18 14:06     ` Matthieu Moy
2013-06-18 14:22       ` Alexander Nestorov
2013-06-18 14:33         ` Matthieu Moy
2013-06-18 14:39           ` Alexander Nestorov
2013-06-18 15:51             ` Alexander Nestorov
2013-06-18 16:00               ` Matthieu Moy
2013-06-18 17:03                 ` Alexander Nestorov
2013-06-19  5:40                   ` Matthieu Moy
2013-06-19  8:00                     ` Alexander Nestorov
2013-06-19 11:37                       ` Matthieu Moy
2013-06-19 18:43                         ` Junio C Hamano [this message]
2013-06-20 13:28                           ` Alexander Nestorov
2013-06-19 16:40                       ` Hilco Wijbenga
2013-06-18 14:01 ` John Keeping
2013-06-18 14:05   ` Alexander Nestorov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vobb2ym99.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Matthieu.Moy@grenoble-inp.fr \
    --cc=alexandernst@gmail.com \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.