All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Heiko Voigt <hvoigt@hvoigt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] teach the user to be nice to git and let him say please sometimes
Date: Sun, 12 May 2013 14:19:34 -0700	[thread overview]
Message-ID: <7vobcfvqu1.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20130511201928.GA22938@book.hvoigt.net> (Heiko Voigt's message of "Sat, 11 May 2013 22:20:16 +0200")

Heiko Voigt <hvoigt@hvoigt.net> writes:

> Since ages we do not care about our program enough. Lets not treat them
> as slaves anymore and say please.
>
> Signed-off-by: Heiko Voigt <hvoigt@hvoigt.net>
> Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
> Signed-off-by: Jens Lehmann <Jens.Lehmann@web.de>
> Signed-off-by: Thomas Rast <trast@inf.ethz.ch>
> Signed-off-by: Johan Herland <johan@herland.net>

So these were the ones present on the dev-day?

I actually would have expected, from the "please" title, the
opposite, us saying "please" to the user, either once in a while in
the advice messages we give to them, or perhaps in the en_POLITE
locale ;-)

>  .gitignore                       |  1 +
>  Makefile                         |  1 +
>  builtin.h                        |  1 +
>  builtin/config.c                 | 23 ++-----------------
>  builtin/please.c                 |  9 ++++++++
>  cache.h                          |  1 +
>  config.c                         | 23 +++++++++++++++++++
>  contrib/completion/git-prompt.sh |  5 +++-
>  git.c                            | 49 +++++++++++++++++++++++++++++++++++++++-

There is no test to protect this feature from future breakages?

  parent reply	other threads:[~2013-05-12 21:19 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-05-11 20:20 [PATCH] teach the user to be nice to git and let him say please sometimes Heiko Voigt
2013-05-12 10:07 ` Ramkumar Ramachandra
2013-05-12 10:23 ` Duy Nguyen
2013-05-13 13:30   ` Heiko Voigt
2013-05-13 13:58     ` Duy Nguyen
2013-05-12 21:19 ` Junio C Hamano [this message]
2013-05-13 13:44   ` Heiko Voigt
2013-05-13 20:40     ` Thomas Rast
2013-05-13 20:47       ` Junio C Hamano
  -- strict thread matches above, loose matches on Subject: below --
2013-05-12  7:26 Heiko Voigt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vobcfvqu1.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=hvoigt@hvoigt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.