From mboxrd@z Thu Jan 1 00:00:00 1970 From: Junio C Hamano Subject: Re: [PATCH 16/33] t3210: test for spurious error messages for dangling packed refs Date: Mon, 15 Apr 2013 10:39:08 -0700 Message-ID: <7vobdfvglf.fsf@alter.siamese.dyndns.org> References: <1365944088-10588-1-git-send-email-mhagger@alum.mit.edu> <1365944088-10588-17-git-send-email-mhagger@alum.mit.edu> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Jeff King , Heiko Voigt , git@vger.kernel.org To: Michael Haggerty X-From: git-owner@vger.kernel.org Mon Apr 15 19:39:25 2013 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1URnN8-00050P-0J for gcvg-git-2@plane.gmane.org; Mon, 15 Apr 2013 19:39:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934113Ab3DORjM (ORCPT ); Mon, 15 Apr 2013 13:39:12 -0400 Received: from b-pb-sasl-quonix.pobox.com ([208.72.237.35]:35660 "EHLO smtp.pobox.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932679Ab3DORjK (ORCPT ); Mon, 15 Apr 2013 13:39:10 -0400 Received: from smtp.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 7BB2D15C6E; Mon, 15 Apr 2013 17:39:10 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; s=sasl; bh=oNXkoNg/kzvRP46iwzvjQSjMKDg=; b=DEtD/X23CJwXmKEMOxLO 7+7EkemSA6nP6yTeJ3HOfYy9KvLCaUJFKvGcYR6R/ChCz+8UrwTHOuAqPaux0dpG UQCMWuSB9qZzmSz2D+xUt/Hh/101KnJwsPP8oDcS8i9wIxSUnXv7gMED4e0Najdu 79xVpuFEdX2CBkAQI82ZA1E= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:message-id:mime-version:content-type; q=dns; s=sasl; b=cmgGgw7oS5MKMpaf0UdhjcCKURiFmkjqIUs2/K/NYTNlLg 3sTxUp/TxORPyHMmzb4iQdo34oj88M01Vh4ecoP6TctKGO7n6/W/Ji/dHy/yvP8t ++hkt0DlARX+r41UIsNExQUBqMzc/2+Xs/AptAeU8lk9zC+QPh8pArawujiiI= Received: from b-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by b-sasl-quonix.pobox.com (Postfix) with ESMTP id 736C915C6D; Mon, 15 Apr 2013 17:39:10 +0000 (UTC) Received: from pobox.com (unknown [24.4.35.13]) (using TLSv1 with cipher DHE-RSA-AES128-SHA (128/128 bits)) (No client certificate requested) by b-sasl-quonix.pobox.com (Postfix) with ESMTPSA id E996015C6C; Mon, 15 Apr 2013 17:39:09 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) X-Pobox-Relay-ID: 6120188E-A5F3-11E2-9D3C-8341C8FBB9E7-77302942!b-pb-sasl-quonix.pobox.com Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: Michael Haggerty writes: > A packed reference can be overridden by a loose reference, in which > case the packed reference is obsolete and is never used. The object > pointed to by such a reference can be garbage collected. Since > d66da478f2, this could lead to the emission of a spurious error > message: > > error: refs/heads/master does not point to a valid object! > > The error is generated by repack_without_ref() if there is an obsolete > dangling packed reference in packed-refs when the packed-refs file has > to be rewritten due to the deletion of another packed reference. Add > a failing test demonstrating this problem and some passing tests of > related scenarios. That is one nasty recent bug. > > Signed-off-by: Michael Haggerty > --- > > How can I get rid of the sleeps in these tests? Would test-chmtime help?