All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: John Keeping <john@keeping.me.uk>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] Documentation: don't link to example mail addresses
Date: Sun, 16 Dec 2012 21:29:24 -0800	[thread overview]
Message-ID: <7vobhtnt57.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <20121215150314.GC2725@river.lan> (John Keeping's message of "Sat, 15 Dec 2012 15:03:15 +0000")

John Keeping <john@keeping.me.uk> writes:

> I can't see any other uses of the "$$" quote in the documentation, so
> it's probably worth noting that I've tested this with Asciidoc 8.6.8,
> although I can't see anything in the changelog to indicate that
> Asciidoc's treatment of it has changed recently.

Thanks.

>  Documentation/git-fast-import.txt | 2 +-
>  Documentation/git-tag.txt         | 2 +-
>  Documentation/mailmap.txt         | 2 +-
>  3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/Documentation/git-fast-import.txt b/Documentation/git-fast-import.txt
> index d1844ea..05913cc 100644
> --- a/Documentation/git-fast-import.txt
> +++ b/Documentation/git-fast-import.txt
> @@ -427,7 +427,7 @@ they made it.
>  
>  Here `<name>` is the person's display name (for example
>  ``Com M Itter'') and `<email>` is the person's email address
> -(``cm@example.com'').  `LT` and `GT` are the literal less-than (\x3c)
> +(``$$cm@example.com$$'').  `LT` and `GT` are the literal less-than (\x3c)
>  and greater-than (\x3e) symbols.  These are required to delimit
>  the email address from the other fields in the line.  Note that
>  `<name>` and `<email>` are free-form and may contain any sequence

AsciiDoc 8.5.2 gives this:   

    asciidoc: WARNING: git-fast-import.txt: line 434: nested inline passthrough

Also in git-fast-import.1, there is this line:

    ... person\(cqs display name (for example `Com M Itter\(aq\(aq) and `<ema...

(notice two leftover `s); not that this is a new issue with this patch.

Which is puzzling, because the next input line formats better:

    ...  email address (\(lqcm@example\&.com\(rq)\&. ...

Other two hunks for git-tag and mailmap seem to give us a better
results.

  parent reply	other threads:[~2012-12-17  5:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-12-15 15:03 [PATCH] Documentation: don't link to example mail addresses John Keeping
2012-12-15 17:20 ` Jeff King
2012-12-15 18:00   ` Junio C Hamano
2012-12-15 18:24   ` John Keeping
2012-12-16 12:04     ` Jeff King
2012-12-16 14:00       ` [PATCH v2] " John Keeping
2012-12-16 18:48         ` Junio C Hamano
2012-12-17  2:24         ` Junio C Hamano
2012-12-17 12:02           ` Jeff King
2012-12-17 19:57             ` Junio C Hamano
2012-12-17  5:29 ` Junio C Hamano [this message]
2012-12-17  9:44   ` [PATCH] " John Keeping

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vobhtnt57.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=john@keeping.me.uk \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.