From: Junio C Hamano <gitster@pobox.com>
To: Yann Dirson <ydirson@altern.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 1/3] Fix error in diff_filepair::status documentation.
Date: Sat, 01 Nov 2008 23:31:11 -0700 [thread overview]
Message-ID: <7vod0y3ahc.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20081101220314.1116.79924.stgit@gandelf.nowhere.earth> (Yann Dirson's message of "Sat, 01 Nov 2008 23:03:14 +0100")
Yann Dirson <ydirson@altern.org> writes:
> Signed-off-by: Yann Dirson <ydirson@altern.org>
> ---
>
> diffcore.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/diffcore.h b/diffcore.h
> index 713cca7..05d0898 100644
> --- a/diffcore.h
> +++ b/diffcore.h
> @@ -62,7 +62,7 @@ struct diff_filepair {
> struct diff_filespec *one;
> struct diff_filespec *two;
> unsigned short int score;
> - char status; /* M C R N D U (see Documentation/diff-format.txt) */
> + char status; /* M C R A D U etc. (see DIFF_STATUS_* in diff.h) */
I think you spotted the right bug and fixed it in a wrong way. The status
letters are user visible, and "git grep status Documentation/*diff*"
mention it in handful places without listing its repertoire, which _is_
the bug.
next prev parent reply other threads:[~2008-11-02 6:32 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-01 22:03 [PATCH v3 0/3] Detection of directory renames Yann Dirson
2008-11-01 22:03 ` [PATCH 1/3] Fix error in diff_filepair::status documentation Yann Dirson
2008-11-02 6:31 ` Junio C Hamano [this message]
2008-11-01 22:03 ` [PATCH 2/3] Introduce rename factorization in diffcore Yann Dirson
2008-11-07 1:10 ` Junio C Hamano
2008-11-07 19:39 ` Yann Dirson
2008-11-07 20:19 ` Junio C Hamano
2008-11-07 20:39 ` Yann Dirson
2008-11-07 21:11 ` Junio C Hamano
2008-11-07 22:12 ` Yann Dirson
2008-11-07 23:43 ` Junio C Hamano
2008-11-08 0:29 ` Yann Dirson
2008-11-08 0:47 ` Junio C Hamano
2008-11-08 0:50 ` Yann Dirson
2008-11-01 22:03 ` [PATCH 3/3] Add testcases for the --factorize-renames diffcore flag Yann Dirson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vod0y3ahc.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git@vger.kernel.org \
--cc=ydirson@altern.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.