All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Jeff King <peff@peff.net>
Cc: Nanako Shiraishi <nanako3@lavabit.com>,
	Andreas Ericsson <ae@op5.se>,
	git@vger.kernel.org
Subject: Re: [PATCH 0/4] tests: use "git xyzzy" form
Date: Wed, 03 Sep 2008 14:22:05 -0700	[thread overview]
Message-ID: <7vod359b7m.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080903210920.GA3199@coredump.intra.peff.net> (Jeff King's message of "Wed, 3 Sep 2008 17:09:20 -0400")

Jeff King <peff@peff.net> writes:

> On Wed, Sep 03, 2008 at 04:59:45PM -0400, Jeff King wrote:
>
>> I just checked 1/4, which looks fine. Made much easier by the use of
>> --color-words (even easier with -U0, but sometimes the context is
>> helpful for seeing that it is correct).
>> 
>> In 2/4, we change some instances of git-upload-pack, which you otherwise
>> mentioned in your "should be left". It's in t5530 and t5602. Otherwise
>> looks fine.
>
> And 3/4 and 4/4 look fine to me, too.

Thanks, both.  All four patches queued (with the tweak I mentioned to the
test title of t5300 and t5305 in an earlier message).

      reply	other threads:[~2008-09-03 21:23 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-03  8:59 [PATCH 0/4] tests: use "git xyzzy" form Nanako Shiraishi
2008-09-03 10:55 ` Andreas Ericsson
2008-09-03 20:01   ` Junio C Hamano
2008-09-03 20:45     ` Junio C Hamano
2008-09-03 20:59       ` Jeff King
2008-09-03 21:09         ` Jeff King
2008-09-03 21:22           ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vod359b7m.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=ae@op5.se \
    --cc=git@vger.kernel.org \
    --cc=nanako3@lavabit.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.