All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: git@vger.kernel.org
Cc: Brian Downing <bdowning@lavos.net>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	Lars Magne Ingebrigtsen <larsi+gmane@gnus.org>
Subject: Applying patches from gmane can be dangerous.
Date: Wed, 06 Feb 2008 20:14:31 -0800	[thread overview]
Message-ID: <7vodatqu6w.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080205211044.GP26392@lavos.net> (Brian Downing's message of "Tue, 5 Feb 2008 15:10:44 -0600")

I picked up the qsort patch from Brian while reading the list
via gmane's newsfeed and applied it without realizing that it
was one of the articles whose addresses on all the address
header fields _and_ all strings that look like e-mail addresses
have been mangled by gmane.  Sign-offs by Dscho and Steffen
Prohaska have also been munged (even though that are not part of
headers).

It already is part of 'next', and we have the policy of not
rewinding 'next', so the record of this mistake will
unfortunately be with us forever.  Sorry, Brian, Dscho and
Steffen.

For the curious, the message was:

    http://article.gmane.org/gmane.comp.version-control.git/72699/raw

I've added the following in my .git/hooks/applypatch-msg and
made it executable, so hopefully it won't happen again.

    #!/bin/sh
    case "$GIT_AUTHOR_EMAIL" in
    *@public.gmane.org)
            echo >&2 "Gmane munged the author's email address, aborting."
            echo >&2 "Pick up the original message from your mbox!"
            exit 1
            ;;
    esac

This is really sad.  gmane gives us a clean threaded interface
(both in web and newsreader), and it never forgets. Whenever I
need to refer somebody to an old discussion, I can give an URL
to it and allmost all the discussion messages are there with a
single paste and clicking around.  It has been an indispensable
service to me ever since I started reading the git list with it.
It is really a shame that I have to prevent picking up patch
messages from it with the above hook.

I am wondering if other development communities had a similar
issue already, and if so how they are dealing with it.

  parent reply	other threads:[~2008-02-07  4:15 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-02-05 21:10 [PATCH v2] compat: Add simplified merge sort implementation from glibc Brian Downing
     [not found] ` <20080205211044.GP26392-oU/tDdhfGLReoWH0uzbU5w@public.gmane.org>
2008-02-05 22:21   ` Johannes Schindelin
     [not found]     ` <alpine.LSU.1.00.0802052220500.8543-OGWIkrnhIhzN0uC3ymp8PA@public.gmane.org>
2008-02-06  2:47       ` Brian Downing
2008-02-07  4:14 ` Junio C Hamano [this message]
2008-02-07  4:29   ` Applying patches from gmane can be dangerous Nicolas Pitre
2008-02-07  9:08     ` Junio C Hamano
2008-02-10 10:51       ` 'next' will be rewound and rebuilt after feature releases Junio C Hamano
2008-02-07  8:01   ` Applying patches from gmane can be dangerous Jari Aalto
2008-02-07  8:21     ` Junio C Hamano
2008-02-07  9:05       ` Mike Hommey
2008-02-07 12:42       ` Johannes Schindelin
2008-02-07 13:32   ` Brian Downing
2008-02-07 14:50     ` Aidan Van Dyk
2008-02-07 15:03       ` Brian Downing
2008-02-07 16:10       ` Johannes Schindelin
2008-02-11 21:16         ` Johannes Schindelin
2008-02-07 14:10   ` Frank Lichtenheld

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vodatqu6w.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=bdowning@lavos.net \
    --cc=git@vger.kernel.org \
    --cc=larsi+gmane@gnus.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.