All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "David D. Kilzer" <ddkilzer@kilzer.net>
Cc: Eric Wong <normalperson@yhbt.net>, git@vger.kernel.org
Subject: Re: [PATCH] Fix race condition in t9119-git-svn-info.sh
Date: Mon, 31 Dec 2007 14:29:15 -0800	[thread overview]
Message-ID: <7vodc65whw.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1199131665-1633-1-git-send-email-ddkilzer@kilzer.net> (David D. Kilzer's message of "Mon, 31 Dec 2007 12:07:45 -0800")

"David D. Kilzer" <ddkilzer@kilzer.net> writes:

> Changed the ptouch bash function to use the "Text Last Updated"
> date reported by 'svn info' when changing the modified time
> (mtime) of the file/symlink/directory in the git working
> directory.  Previously it used the mtime of the item in the
> svn working directory, which caused the race condition.
>
> Signed-off-by: David D. Kilzer <ddkilzer@kilzer.net>

> @@ -350,8 +355,8 @@ test_expect_success 'info unknown-symlink-directory' "
>  	cd svnwc &&
>  		ln -s unknown-directory unknown-symlink-directory &&
>  	cd .. &&
> -	ptouch gitwc/unknown-symlink-directory \
> -	       svnwc/unknown-symlink-directory &&
> +	ptouch svnwc/unknown-symlink-directory \
> +	       gitwc/unknown-symlink-directory &&

Hmph.  Am I the only one who finds this repetition somewhat
disturbing?

  reply	other threads:[~2007-12-31 22:29 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-10-22  6:11 What's in git/spearce.git (stable) Shawn O. Pearce
2007-11-01  5:39 ` What's in git.git (stable) Junio C Hamano
2007-11-04  3:52   ` Junio C Hamano
2007-11-08  8:06     ` Junio C Hamano
2007-11-08 11:38       ` Pierre Habouzit
2007-11-12  7:06       ` Junio C Hamano
2007-11-15  0:20         ` Junio C Hamano
2007-11-17 21:00           ` Junio C Hamano
2007-11-25 20:45             ` Junio C Hamano
2007-12-01  2:05               ` Junio C Hamano
2007-12-04  8:43                 ` Junio C Hamano
2007-12-05 10:57                   ` Junio C Hamano
2007-12-07  9:50                     ` Junio C Hamano
2007-12-09 10:32                       ` Junio C Hamano
2007-12-10 22:37                         ` v1.5.4 plans Junio C Hamano
2007-12-10 23:49                           ` Jeff King
2007-12-11  1:27                             ` Junio C Hamano
2007-12-11  5:02                               ` Junio C Hamano
2007-12-11  6:39                                 ` Jeff King
2007-12-11  6:47                                   ` Junio C Hamano
2007-12-11  6:54                                     ` Jeff King
2007-12-11  7:00                                       ` Junio C Hamano
2007-12-11  7:03                                         ` Jeff King
2007-12-11  6:17                               ` Jeff King
2007-12-11  6:27                                 ` Jeff King
2007-12-11  6:28                                 ` [PATCH 2/2] git-svn: get color config from --get-colorbool Jeff King
2007-12-12 18:27                                   ` Eric Wong
2007-12-11  7:01                               ` v1.5.4 plans Jeff King
2007-12-11  7:05                               ` Andreas Ericsson
2007-12-11 12:53                               ` Jeff King
2007-12-11  3:53                           ` Nicolas Pitre
2007-12-11 12:57                             ` Johannes Schindelin
2007-12-11 13:59                               ` Nicolas Pitre
2007-12-11 15:24                           ` Kristian Høgsberg
2007-12-11 19:13                             ` Junio C Hamano
2007-12-12 18:40                           ` Eric Wong
2007-12-12 19:50                             ` Junio C Hamano
2007-12-12 22:21                               ` David D. Kilzer
2007-12-31  3:56                             ` David D. Kilzer
2007-12-31 20:07                               ` [PATCH] Fix race condition in t9119-git-svn-info.sh David D. Kilzer
2007-12-31 22:29                                 ` Junio C Hamano [this message]
2007-12-31 23:33                                   ` [PATCH] Remove duplication " David D. Kilzer
2008-01-02  3:43                                     ` Eric Wong
2008-01-02  3:54                                       ` David D. Kilzer
2008-01-02  5:57                                       ` Junio C Hamano
2008-01-02 10:27                                       ` Junio C Hamano
2007-12-13  2:47                         ` What's in git.git (stable frozen) Junio C Hamano
2007-12-13  3:09                           ` [PATCH] git-commit: squelch needless message during an empty merge Junio C Hamano
2007-12-13  4:34                             ` Jeff King
2007-12-13  7:46                             ` Johannes Sixt
2007-12-17  8:40                           ` What's in git.git (stable frozen) Junio C Hamano
2007-12-23  9:21                             ` Junio C Hamano
2008-01-05 10:46                               ` Junio C Hamano
2008-01-05 21:21                                 ` Dan McGee
2008-01-06  2:56                                   ` Junio C Hamano
2008-01-06  3:06                                     ` Junio C Hamano
2008-01-06  3:08                                       ` Dan McGee
2008-01-06 10:33                                         ` Junio C Hamano
     [not found]                                 ` <e5bfff550801050507x369976b7sd5e112451bc90331@mail.gmail.com>
2008-01-05 22:11                                   ` Junio C Hamano
2008-01-06  4:24                                 ` Jeff King
2008-01-06  4:29                                   ` Jeff King
2008-01-06 10:51                                     ` Junio C Hamano
2008-01-06 11:17                                       ` Jeff King
2008-01-06 12:32                                         ` Junio C Hamano
2008-01-06 20:59                                           ` Jeff King
2008-01-06 21:22                                             ` Junio C Hamano
2008-01-07  1:48                                               ` Jeff King
2008-01-07  8:27                                 ` Junio C Hamano
2008-01-07 21:58                                   ` Paul Mackerras
2008-01-07 22:05                                     ` Christian Stimming
2008-01-07 22:14                                       ` Junio C Hamano
2007-12-17 21:52                           ` Steffen Prohaska

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vodc65whw.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=ddkilzer@kilzer.net \
    --cc=git@vger.kernel.org \
    --cc=normalperson@yhbt.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.