All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "David D. Kilzer" <ddkilzer@kilzer.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH v2] git-send-email: show all headers when sending mail
Date: Mon, 19 Nov 2007 00:17:51 -0800	[thread overview]
Message-ID: <7voddqodhs.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <1195445695-27262-1-git-send-email-ddkilzer@kilzer.net> (David D. Kilzer's message of "Sun, 18 Nov 2007 20:14:55 -0800")

Thanks.  Looks nice and obviously correct.

One thing that has been bugging me for a long time now stands
out like a sore thumb much more: empty Cc: is shown.

    $ git-send-email --dry-run --to=junio@my.isp.net 0001-branch-contains.txt
    Who should the emails appear to be from? [Junio C Hamano <gitster@pobox.com>]
    Emails will be sent from: Junio C Hamano <gitster@pobox.com>
    Message-ID to be used as In-Reply-To for the first email?
    0001-branch-contains.txt
    Dry-OK. Log says:
    Date: Mon, 19 Nov 2007 00:10:04 -0800
    Server: my.isp.net
    MAIL FROM:<gitster@pobox.com>
    RCPT TO:<junio@my.isp.net>
    From: Junio C Hamano <gitster@pobox.com>
    Subject: [PATCH] branch --contains=<commit>
    Cc:
    To: junkio@cox.net

    Result: OK

  reply	other threads:[~2007-11-19  8:18 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-11-12 16:01 [PATCH] git-send-email: show all headers when sending mail David D. Kilzer
2007-11-13  7:28 ` Junio C Hamano
2007-11-19  4:14   ` [PATCH v2] " David D. Kilzer
2007-11-19  8:17     ` Junio C Hamano [this message]
2007-11-19 10:48       ` [PATCH] Don't print an empty Cc header in SMTP mode when there's no cc recipient defined Ask Bjørn Hansen
2007-11-19 18:50       ` [PATCH v2] git-send-email: show all headers when sending mail David D. Kilzer
2007-11-20  1:53         ` Ask Bjørn Hansen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7voddqodhs.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=ddkilzer@kilzer.net \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.