From: Junio C Hamano <gitster@pobox.com>
To: Jonas Fonseca <fonseca@diku.dk>
Cc: git@vger.kernel.org, spearce@spearce.org
Subject: Re: [PATCH] Mention that git-branch -M can cause problems for tracking branches
Date: Fri, 02 Nov 2007 15:30:53 -0700 [thread overview]
Message-ID: <7vodecz3du.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20071102220411.GA13666@diku.dk> (Jonas Fonseca's message of "Fri, 2 Nov 2007 23:04:11 +0100")
Jonas Fonseca <fonseca@diku.dk> writes:
> The main reason to "refuse" the removal is that for the general case,
> e.g. when using `git-config --rename-section`, this can potentially lead
> to loss of valuable config settings. This was pointed out by Shawn in
> his reply to my patch[0]. I agreed to this in my follow-up and asked if
> it would be acceptable to add an additional flag to so that git-branch
> can switch on this request for removal.
So when you rename branch.foo section to branch.bar, instead of
replacing the whole existing branch.bar with what used to be in
branch.foo, you _append_ that to branch.bar?
That sounds insane.
What good does it do to keep what used to be branch.bar? The
old contents in the section are by no means "valuable". They
were about 'bar' and do not even have anything to do with the
branch being renamed, which used to be called 'foo'.
Shawn's example of modifying multi-valued variable is
irrelevant. Over there, we have options to replace everything
or append to it, don't we?
If the option is --rename-section, that is "rename section", not
"merge section". If for some reason a merge section operation
is needed, that should be supplied in a separate patch, but for
the branch renaming I really do not see the need for it.
prev parent reply other threads:[~2007-11-02 22:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-11-02 9:17 [PATCH] Mention that git-branch -M can cause problems for tracking branches Jonas Fonseca
2007-11-02 20:14 ` Junio C Hamano
2007-11-02 22:04 ` Jonas Fonseca
2007-11-02 22:30 ` Junio C Hamano [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodecz3du.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=fonseca@diku.dk \
--cc=git@vger.kernel.org \
--cc=spearce@spearce.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.