From: Junio C Hamano <junkio@cox.net>
To: Petr Baudis <pasky@suse.cz>
Cc: "Ilpo Järvinen" <ilpo.jarvinen@helsinki.fi>, git@vger.kernel.org
Subject: Re: [PATCH] Fixes git-cherry algorithmic flaws
Date: Sun, 24 Sep 2006 10:47:29 -0700 [thread overview]
Message-ID: <7vodt59mxa.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <20060924111737.GL20017@pasky.or.cz> (Petr Baudis's message of "Sun, 24 Sep 2006 13:17:38 +0200")
Petr Baudis <pasky@suse.cz> writes:
> Hmm, well, what's curious is that the documentation says
>
> Every commit with a changeset that doesn't exist in the other branch
> has its id (sha1) reported, prefixed by a symbol. Those existing only
> in the <upstream> branch are prefixed with a minus (-) sign, and those
> that only exist in the <head> branch are prefixed with a plus (+)
> symbol.
>
> which is in contradiction of Ilpo's description of the old algorithm
> (and also your description of it). It would seem he just wants to fix it
> according to the documented behaviour.
>
> I guess the documentation is what's broken then?
Ah I did not realize that, but yes the documentation is
incorrect.
I wonder if we can kill it by introducing a new rev notation and
using regular rev-list family of commands instead.
What we want here is a way to say "give me commits that are in B
but not in A, but before returning a commit see if there is an
equivalent change in the set of commits that are in A but not in
B, and filter it out".
Time for "rev-list A....B"? ;-)
next prev parent reply other threads:[~2006-09-24 17:47 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-07 10:30 [PATCH] Fixes git-cherry algorithmic flaws Ilpo Järvinen
2006-09-24 0:00 ` Petr Baudis
2006-09-24 1:49 ` Junio C Hamano
2006-09-24 11:17 ` Petr Baudis
2006-09-24 17:47 ` Junio C Hamano [this message]
2006-09-24 18:43 ` Ilpo Järvinen
2006-09-24 19:25 ` Jakub Narebski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vodt59mxa.fsf@assigned-by-dhcp.cox.net \
--to=junkio@cox.net \
--cc=git@vger.kernel.org \
--cc=ilpo.jarvinen@helsinki.fi \
--cc=pasky@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.