All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Nicolas Pitre <nico@cam.org>,
	git@vger.kernel.org, Gerrit Pape <pape@smarden.org>
Subject: Re: [PATCH 0/5] add pack index v2 reading capability to git v1.4.4.4
Date: Wed, 16 Jul 2008 10:04:18 -0700	[thread overview]
Message-ID: <7vprpdsqul.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.1.10.0807160924340.2835@woody.linux-foundation.org

Linus Torvalds <torvalds@linux-foundation.org> writes:

> On Wed, 16 Jul 2008, Nicolas Pitre wrote:
>> 
>> Junio: if you could just apply them, tag the result as v1.4.4.5 and
>> push it out then at that point it simply will be up to Debian to make
>> it available as a "major usability fix".
>
> Actually, it fixes a crash. Didn't 1.4.4 SIGSEGV without this on pack-v2?
>
> So you don't even have to sell it as a usability issue, but literally as a 
> bugfix.

It's tagged and pushed out to both kernel.org and repo.or.cz.  Thanks, Nico.

I won't be doing my usual full release engineering on this one, but I did:

 - repack a copy of git.git to use pack idx version #2 for trial.

	Hint.  A handy way to tell which version of packfile you have is
	to run this:

	$ od -c .git/objects/pack/pack-$your_pack_id.idx | head -n 1
        
        If the output begins with "377 t 0 c", you have pack idx version
        #2.

 - check "git log" from v1.4.4.4 (fails) and v1.4.4.5 (reads ok)

 - repack this copy with "git repack" from 1.4.4.5.  This produced a
   repository usable by v1.4.4.4.

I also updated /pub/scm/git/git.git/config at kernel.org to use

	[pack]
        	indexVersion = 1

for now.  The repository is also repacked with pack idx version #1.

  reply	other threads:[~2008-07-16 17:05 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-16  6:31 [PATCH 0/5] add pack index v2 reading capability to git v1.4.4.4 Nicolas Pitre
2008-07-16  6:31 ` [PATCH 1/5] clean up pack index handling a bit Nicolas Pitre
2008-07-16  6:31   ` [PATCH 2/5] clean up and optimize nth_packed_object_sha1() usage Nicolas Pitre
2008-07-16  6:31     ` [PATCH 3/5] get rid of num_packed_objects() Nicolas Pitre
2008-07-16  6:31       ` [PATCH 4/5] pack-objects: learn about pack index version 2 Nicolas Pitre
2008-07-16  6:31         ` [PATCH 5/5] sha1_file.c: learn about " Nicolas Pitre
2008-07-16 10:46 ` [PATCH 0/5] add pack index v2 reading capability to git v1.4.4.4 Johannes Schindelin
2008-07-16 16:25 ` Linus Torvalds
2008-07-16 17:04   ` Junio C Hamano [this message]
2008-07-16 17:08   ` Junio C Hamano
2008-07-16 17:34     ` Linus Torvalds
2008-07-17  8:01       ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprpdsqul.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=nico@cam.org \
    --cc=pape@smarden.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.