All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Shawn O. Pearce" <spearce@spearce.org>
Cc: Eric Raible <raible@gmail.com>,
	Git Mailing List <git@vger.kernel.org>,
	szeder@ira.uka.de
Subject: Re: [PATCH] completion: add branch options --contains --merged --no-merged
Date: Mon, 07 Jul 2008 22:30:17 -0700	[thread overview]
Message-ID: <7vprppvt7a.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <20080708044922.GD2542@spearce.org> (Shawn O. Pearce's message of "Tue, 8 Jul 2008 04:49:22 +0000")

"Shawn O. Pearce" <spearce@spearce.org> writes:

> Eric Raible <raible@gmail.com> wrote:
>> Signed-off-by: Eric Raible <raible@gmail.com>
>
> Trivially-Acked-by: Shawn O. Pearce <spearce@spearce.org>
>
> ;-)
>
> More completion support that probably should go to maint, as the
> functionality in git-branch is in 1.5.6 but we (again) forgot to
> make sure the completion was up-to-date prior to release.

I am actually getting more worried about completion code getting larger
and larger without its performance impact not being looked at nor
addressed adequately.  In my regular working tree:

	$ echo Docu<TAB>

completes "mentation/" instantly, but:

	$ git log -- Docu<TAB>

takes about 1.5 to 2 seconds to complete the same.

  reply	other threads:[~2008-07-08  5:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-07 20:41 [PATCH] completion: add branch options --contains --merged --no-merged Eric Raible
2008-07-08  4:49 ` Shawn O. Pearce
2008-07-08  5:30   ` Junio C Hamano [this message]
2008-07-08 11:36     ` Johannes Schindelin
2008-07-08 16:56       ` [PATCH] bash: offer only paths after '--' SZEDER Gábor
2008-07-08 17:46         ` Eric Raible
2008-07-08 20:21         ` Junio C Hamano
2008-07-08 23:18           ` Shawn O. Pearce
2008-07-08 23:23             ` Junio C Hamano
2008-07-08 23:51             ` SZEDER Gábor
2008-07-08 23:55               ` Shawn O. Pearce
2008-07-09  0:06               ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vprppvt7a.fsf@gitster.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=raible@gmail.com \
    --cc=spearce@spearce.org \
    --cc=szeder@ira.uka.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.