From: Junio C Hamano <gitster@pobox.com>
To: Daniel Barkalow <barkalow@iabervon.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Git Mailing List <git@vger.kernel.org>,
Kristian H?gsberg <krh@redhat.com>
Subject: Re: performance problem: "git commit filename"
Date: Sun, 13 Jan 2008 00:14:37 -0800 [thread overview]
Message-ID: <7vprw6qh02.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: <alpine.LNX.1.00.0801130028460.13593@iabervon.org> (Daniel Barkalow's message of "Sun, 13 Jan 2008 00:38:51 -0500 (EST)")
Daniel Barkalow <barkalow@iabervon.org> writes:
> On Sat, 12 Jan 2008, Linus Torvalds wrote:
>
>> It makes builtin-commit.c use the same logic that "git read-tree -i -m"
>> does (which is what the old shell script did), and it seems to pass the
>> test-suite, and it looks pretty obvious.
>
> The only issue I know about with using unpack_trees in C as a replacement
> for read-tree in shell is that unpack_trees leaves "deletion" index
> entries in memory which are not written to disk,...
I do not think you have to worry about that one. That "to be
deleted" was a Linus invention and he surely remembers it.
write_index() function of course knows about skipping them (they
are marked as !ce->ce_mode). I think the patch is safe.
next prev parent reply other threads:[~2008-01-13 8:15 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-01-12 22:46 performance problem: "git commit filename" Linus Torvalds
2008-01-13 1:46 ` Linus Torvalds
2008-01-13 4:04 ` Linus Torvalds
2008-01-13 5:38 ` Daniel Barkalow
2008-01-13 8:14 ` Junio C Hamano [this message]
2008-01-13 16:57 ` Linus Torvalds
2008-01-13 19:31 ` Daniel Barkalow
2008-01-13 8:12 ` Junio C Hamano
2008-01-13 10:33 ` Junio C Hamano
2008-01-13 10:54 ` [PATCH] builtin-commit.c: do not lstat(2) partially committed paths twice Junio C Hamano
2008-01-13 11:09 ` performance problem: "git commit filename" Junio C Hamano
2008-01-13 17:24 ` Linus Torvalds
2008-01-13 19:39 ` Junio C Hamano
2008-01-13 22:36 ` [PATCH] index: be careful when handling long names Junio C Hamano
2008-01-13 22:53 ` Alex Riesen
2008-01-13 23:08 ` Junio C Hamano
2008-01-13 23:33 ` Alex Riesen
2008-01-14 21:03 ` Junio C Hamano
2008-01-14 1:00 ` performance problem: "git commit filename" Junio C Hamano
2008-01-14 17:07 ` Linus Torvalds
2008-01-14 18:38 ` Junio C Hamano
2008-01-14 19:39 ` Linus Torvalds
2008-01-14 20:08 ` Junio C Hamano
2008-01-14 21:00 ` Linus Torvalds
2008-01-15 0:18 ` Linus Torvalds
2008-01-15 1:13 ` Junio C Hamano
2008-01-13 10:38 ` [PATCH] builtin-commit.c: remove useless check added by faulty cut and paste Junio C Hamano
2008-01-14 21:23 ` しらいしななこ
2008-01-14 21:54 ` Junio C Hamano
2008-01-14 23:46 ` performance problem: "git commit filename" Kristian Høgsberg
2008-01-14 23:15 ` Kristian Høgsberg
2008-01-14 23:48 ` Junio C Hamano
2008-01-14 23:53 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vprw6qh02.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=barkalow@iabervon.org \
--cc=git@vger.kernel.org \
--cc=krh@redhat.com \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.