All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: "Bradford Smith" <bradford.carl.smith@gmail.com>
Cc: "Nikolai Weibull" <now@bitwi.se>, git@vger.kernel.org
Subject: Re: git-config: replaces ~/.gitconfig symlink with real file
Date: Mon, 16 Jul 2007 15:46:17 -0700	[thread overview]
Message-ID: <7vps2s2chy.fsf@assigned-by-dhcp.cox.net> (raw)
In-Reply-To: <f158199e0707160626j1025ab2cp3339ca6ab91d9af0@mail.gmail.com> (Bradford Smith's message of "Mon, 16 Jul 2007 09:26:01 -0400")

"Bradford Smith" <bradford.carl.smith@gmail.com> writes:

> ...  So, I guess I need to add a GIT_CONFIG_HOME
> environment variable.

I suspect that is going down a wrong path.

We use the sequence:

	fd = creat("temporary location");
        write(fd, ...);
        close(fd);
        rename("temporary location", "final location");

in quite a lot of codepaths.  I think they can be factored out,
to take the "final location" (and perhaps a suggested temporary
directory) as an parameter, and that code can check that "final
location" is a symlink to somewhere else and create the
temporary next to the target file.

  reply	other threads:[~2007-07-16 22:46 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-07-15 21:27 git-config: replaces ~/.gitconfig symlink with real file Bradford Smith
2007-07-15 23:30 ` Johannes Schindelin
2007-07-16  9:37 ` Nikolai Weibull
2007-07-16 11:33   ` Bradford Smith
2007-07-16 13:26     ` Bradford Smith
2007-07-16 22:46       ` Junio C Hamano [this message]
2007-07-25 16:49         ` [PATCH 0/2] git-config should not replace symlink Bradford C. Smith
2007-07-25 16:49           ` [PATCH 1/2] resolve symlinks when creating lockfiles Bradford C. Smith
2007-07-25 16:49             ` [PATCH 2/2] use lockfile.c routines in git_commit_set_multivar() Bradford C. Smith
2007-07-25 23:35             ` [PATCH 1/2] resolve symlinks when creating lockfiles Junio C Hamano
2007-07-26 16:55               ` [PATCH] use lockfile.c routines in git_commit_set_multivar() Bradford C. Smith
2007-07-26 18:31                 ` Johannes Schindelin
2007-07-26 18:48                   ` Bradford Smith
2007-07-27  4:30                     ` Junio C Hamano
2007-07-27  4:53                       ` Junio C Hamano
2007-07-27  9:05                         ` Johannes Schindelin
2007-07-27 18:24                         ` Bradford Smith
2007-07-26 17:34               ` [PATCH] fully resolve symlinks when creating lockfiles Bradford C. Smith
2007-07-26 18:35                 ` Johannes Schindelin
2007-07-26 19:34                 ` Morten Welinder
2007-07-27 16:50                   ` Bradford Smith
2007-07-27  7:05                 ` Junio C Hamano
2007-07-17 13:56       ` git-config: replaces ~/.gitconfig symlink with real file Johannes Schindelin
2007-07-17 14:27         ` Matthieu Moy
2007-07-17 20:35         ` Fredrik Tolf
2007-07-17 20:48           ` Johannes Schindelin
2007-07-17 13:39 ` Catalin Marinas
2007-07-17 16:09   ` Johannes Schindelin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vps2s2chy.fsf@assigned-by-dhcp.cox.net \
    --to=gitster@pobox.com \
    --cc=bradford.carl.smith@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=now@bitwi.se \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.