All of lore.kernel.org
 help / color / mirror / Atom feed
From: Junio C Hamano <gitster@pobox.com>
To: Vincent van Ravesteijn <vfr@lyx.org>
Cc: git@vger.kernel.org
Subject: Re: [PATCHv2] Do not autosquash in case of an implied interactive rebase
Date: Tue, 29 May 2012 11:43:07 -0700	[thread overview]
Message-ID: <7vr4u24ymc.fsf@alter.siamese.dyndns.org> (raw)
In-Reply-To: <4FC3428F.4060202@lyx.org> (Vincent van Ravesteijn's message of "Mon, 28 May 2012 11:17:03 +0200")

Vincent van Ravesteijn <vfr@lyx.org> writes:

> Or did you mean that you want to imply "--interactive" when
> "--autosquash" is explicitly given ?

Come to think of it, it might have been a saner UI design when
f59baa5 (rebase -i --autosquash: auto-squash commits, 2009-12-08)
added this option, but if we want to go that route, we do need to
address the concerns I raised in my response.

But as things stand, i.e. with --autosquash that does not imply -i,
your patch is good.

Thanks.

      parent reply	other threads:[~2012-05-29 18:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24 13:52 [PATCH] Do not autosquash in case of an implied interactive rebase Vincent van Ravesteijn
2012-05-24 13:57 ` [PATCHv2] " Vincent van Ravesteijn
2012-05-25 17:50   ` Junio C Hamano
2012-05-28  9:17     ` Vincent van Ravesteijn
2012-05-29 18:41       ` Junio C Hamano
2012-05-29 18:43       ` Junio C Hamano [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7vr4u24ymc.fsf@alter.siamese.dyndns.org \
    --to=gitster@pobox.com \
    --cc=git@vger.kernel.org \
    --cc=vfr@lyx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.