From: Junio C Hamano <gitster@pobox.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Hermann Gausterer <git-mailinglist@mrq1.org>,
Git Mailinglist <git@vger.kernel.org>
Subject: Re: [BUG] minor: wrong handling of GIT_AUTHOR_DATE
Date: Sat, 16 Aug 2008 19:46:22 -0700 [thread overview]
Message-ID: <7vr68obbpd.fsf@gitster.siamese.dyndns.org> (raw)
In-Reply-To: alpine.LFD.1.10.0808161613520.3324@nehalem.linux-foundation.org
Linus Torvalds <torvalds@linux-foundation.org> writes:
> Junio, your call. But this one gets the date right for strings that just
> randomly have some big number in them, ie
>
> [torvalds@nehalem git]$ ./test-date "17:25:54 917476713 2008-06-04 -0700"
> 17:25:54 917476713 2008-06-04 -0700 -> 1212625554 -0700 -> Wed Jun 4 17:25:54 2008
> 17:25:54 917476713 2008-06-04 -0700 -> Wed Jun 4 17:25:54 2008
Being able to parse this is a very low priority.
You've taught people here and on the kernel list that the "date" can use
any non-digit-non-word as a word separator, and "git log --since 2.days"
is something you often do.
People who followed that advice would have gotten used to this already, e.g.
$ git reflog delete master@{07.04.2005.15:15:00.-0700}
should not be broken.
I think your first hunk needs to distinguish between "very-long-precision
posint" (in which case we ignore because it is likely to be nanoseconds
fraction) and others.
next prev parent reply other threads:[~2008-08-17 2:48 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-16 20:53 [BUG] minor: wrong handling of GIT_AUTHOR_DATE Hermann Gausterer
2008-08-16 23:03 ` Linus Torvalds
2008-08-16 23:17 ` Linus Torvalds
2008-08-17 2:46 ` Junio C Hamano [this message]
2008-08-17 3:13 ` Junio C Hamano
2008-08-17 4:25 ` Linus Torvalds
2008-08-17 4:37 ` Linus Torvalds
2008-08-17 5:27 ` Junio C Hamano
2008-08-17 16:07 ` Linus Torvalds
2008-08-17 3:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7vr68obbpd.fsf@gitster.siamese.dyndns.org \
--to=gitster@pobox.com \
--cc=git-mailinglist@mrq1.org \
--cc=git@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.